Summary: | sysutils/fluent-bit: Upgrade to 1.2.2 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Artyom Davidov <ard_1> | ||||||||
Component: | Individual Port(s) | Assignee: | Palle Girgensohn <girgen> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | nilsjohannsen, val | ||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(girgen) |
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Description
Artyom Davidov
2019-08-20 07:08:25 UTC
Created attachment 206721 [details]
Synth test build log on FreeBSD 11.3
Created attachment 206764 [details] patch-lib_flb__libco_aarch64.c Needs this patch for aarch64 (also @ https://github.com/edsiper/flb_libco/pull/8) And you can switch MASTER_SITES to https:// Since the patch to update fluent-bit to 1.3.1 was recently committed to the ports tree ( https://svnweb.freebsd.org/changeset/ports/513923 ) I don't know if we should keep this open. But as far as I can see that commit is missing the patch from Greg V for aarch64. Also that patch was not incorporated upstream, so I guess it is still needed even for 1.3.1 to be successfully build on aarch64. Sorry to say, I missed this PR for some reason. The patch for ARM is now included. Thanks! Did you make a pull request upstreams, BTW? A commit references this bug: Author: girgen Date: Fri Oct 11 07:48:23 UTC 2019 New revision: 514263 URL: https://svnweb.freebsd.org/changeset/ports/514263 Log: Upgrade to 1.3.2 Release notes: https://fluentbit.io/announcements/v1.3.2/ PR: 239985 Changes: head/sysutils/fluent-bit/Makefile head/sysutils/fluent-bit/distinfo head/sysutils/fluent-bit/files/patch-lib_flb__libco_aarch64.c (In reply to Palle Girgensohn from comment #4) Hello Palle, Greg has made a pull request at flb_libco Github repository as he mentioned earlier in comment #2. But it is not accepted yet by the flb_libco authors. Also there he mentions that flb_libco implementation differs from what it's upstream (libco) have. I'm not quite sure if we should ask fluent-bit authors to incorporate the Greg's fixes in their source tree, 'cause it could bring some more mess to the whole situation. Maybe we should wait for the flb_libco authors to fix this upstream? (In reply to Artyom Davidov from comment #6) The 'flb' in 'flb_libco' stands for 'fluent-bit' :) so it's *their* fork. I pinged the main issue tracker: https://github.com/fluent/fluent-bit/issues/1654 (In reply to Greg V from comment #7) Lol! I didn't realize that, before you pointed it out. =D Thanks for pushing this issue upstream. |