Summary: | games/openomf: Fix build with non-x86 (non-SSE) architectures | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | devel, linimon | ||||
Priority: | --- | Keywords: | easy, needs-qa | ||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(devel) koobs: merge-quarterly? |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
^Triage: - Reporter is committer, assign accordingly - Bugfix, MFH Comment on attachment 206885 [details]
patch
Approved by: portmgr (blanket(s): build fix)
MFH: 2019Q3
Pending QA
Should ${REINPLACE_CMD} -e 's,-msse ,,' be scoped to !x86 archs so as not to affect performance on them? Approved by mentor. (In reply to Kubilay Kocak from comment #3) A commit references this bug: Author: pkubaj Date: Wed Sep 4 09:36:02 UTC 2019 New revision: 511074 URL: https://svnweb.freebsd.org/changeset/ports/511074 Log: games/openomf: Fix build with non-x86 (non-SSE) architectures SSE is only available on x86 platforms and forcing it breaks compilation on other platforms. Clang on 12.0-RELEASE on amd64 enables SSE by default anyway and not-specifying -msse allows to build this port on other, non-SSE architectures. Also add USES=sdl. PR: 240093 Approved by: devel@stasyan.com (maintainer), linimon (mentor) Changes: head/games/openomf/Makefile |
Created attachment 206885 [details] patch SSE is only available on x86 platforms and forcing it breaks compilation on other platforms. Clang on 12.0-RELEASE on amd64 enables SSE by default anyway and not-specifying -msse allows to build this port on other, non-SSE architectures. Also add USES=sdl.