Bug 240096

Summary: www/qutebrowser: tell user how to disable hardware acceleration
Product: Ports & Packages Reporter: Lorenzo Salvadore <salvadore>
Component: Individual Port(s)Assignee: Roman Bogorodskiy <novel>
Status: Closed FIXED    
Severity: Affects Only Me CC: novel
Priority: --- Flags: bugzilla: maintainer-feedback? (novel)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 237277    
Attachments:
Description Flags
qutebrowser --disable-gpu
none
qutebrowser --qt-flag disable-gpu
salvadore: maintainer-approval? (novel)
adds qutebrowser option none

Description Lorenzo Salvadore freebsd_committer 2019-08-25 10:52:37 UTC
On older hardwares or systems where hardware acceleration has not been configured correctly the browser shows videos with wrong colors.

This patch adds in pkg-message the suggestion to disable hardware acceleration through the --disable-gpu option.

Testing is needed to verify that the option works.

See bug #237277.
Comment 1 Lorenzo Salvadore freebsd_committer 2019-08-25 10:53:45 UTC
Created attachment 206889 [details]
qutebrowser --disable-gpu
Comment 2 Roman Bogorodskiy freebsd_committer 2019-08-25 11:52:47 UTC
(In reply to Lorenzo Salvadore from comment #0)

Thanks for reporting this.

However, there seem to be no '--disable-gpu' flag for qutebrowser:

qutebrowser: error: unrecognized arguments: --disable-gpu

Probably the right equivalent is 'qutebrowser --qt-flag disable-gpu', though I see no difference on my system. I guess I'll need to confirm with qutebrowser if that's the right way to disable hardware acceleration.
Comment 3 Lorenzo Salvadore freebsd_committer 2019-08-25 12:00:31 UTC
Created attachment 206892 [details]
qutebrowser --qt-flag disable-gpu

Thanks for feeback.

I updated the patch by replacing --disable-gpu with the --qt-flag disable-gpu option.
Comment 4 Roman Bogorodskiy freebsd_committer 2019-08-25 12:20:17 UTC
Created attachment 206893 [details]
adds qutebrowser option

Upstream configured that 'qt-flag disable-gpu' should work fine. Also updated with the info about configuration settings. Please take a look.
Comment 5 Lorenzo Salvadore freebsd_committer 2019-08-25 12:25:03 UTC
(In reply to Roman Bogorodskiy from comment #4)

Looks great. Let's commit it :)
Comment 6 commit-hook freebsd_committer 2019-08-25 12:32:35 UTC
A commit references this bug:

Author: novel
Date: Sun Aug 25 12:31:50 UTC 2019
New revision: 509793
URL: https://svnweb.freebsd.org/changeset/ports/509793

Log:
  www/qutebrowser: tell user how to disable hardware acceleration

  On older hardwares or systems where hardware acceleration has not been
  configured correctly the browser shows videos with wrong colors.
  Add a pkg-message notice on how to disable hardware acceleration
  as a workaround for this issue.

  PR:		240096
  Submitted by:	Lorenzo Salvadore

Changes:
  head/www/qutebrowser/pkg-message
Comment 7 Roman Bogorodskiy freebsd_committer 2019-08-25 12:33:39 UTC
Committed, thanks!