Bug 240206
| Summary: | net/kamailio: Refactoring | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Wagin <dmitry.wagin> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | dmitry.wagin | ||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||
| Version: | Latest | Flags: | pi:
maintainer-feedback+
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Have you checked with portlint -AC ? I did a testbuild with:
===> The following configuration options are available for kamailio-5.2.4_1:
DATABASE=on: Database support (select one or more)
DIALPLAN=off: Dialplan support
DOCS=on: Build and/or install documentation
JITSI=off: VoIP Frontend GUI via Jitsi
PERL=off: Perl scripting language support
PRESENCE=on: Presence support
RADIUS=on: RADIUS protocol support
SCTP=off: SCTP support
TLS=on: Secure network connection support via TLS
UNIXODBC=off: ODBC backend via unixODBC
WEBSOCKET=off: Websocket support
====> Database support (select one or more): you have to choose at least one of them
MYSQL=off: MySQL database support
PGSQL=on: PostgreSQL database support
and it failed with errors in the plist.
See https://people.freebsd.org/~pi/logs/net__kamailio-120-1567192298.txt
I have not checked why it failed.
Btw, thanks for the cool patch! It is very useful to clean that port up. Created attachment 207043 [details]
kamailio.diff
passed portlint -AC
Created attachment 207044 [details]
poudriere_testport.txt
poudriere testport
(In reply to Kurt Jaeger from comment #2) I think the problem is the patches that need to be removed patch-src_Makefile patch-src_main.c patch-src_modules_ctl_ctl.c patch-src_modules_ctl_ctl__defaults.h patch-src_modules_tls_Makefile patch-utils_kamctl_Makefile Created attachment 207045 [details]
kamailio.diff
with removed files
What value will RUN_DIR have with those patches removed ? (In reply to Kurt Jaeger from comment #8) +RUNDIR?= /var/run/${PORTNAME} post-patch: + @${REINPLACE_CMD} '499s|$$(run_prefix)/$$(run_dir)|${RUNDIR}|' \ + ${WRKSRC}/src/Makefile.defs Ah, now I get it. Thanks! Committed! A commit references this bug: Author: pi Date: Sun Sep 1 15:12:51 UTC 2019 New revision: 510695 URL: https://svnweb.freebsd.org/changeset/ports/510695 Log: net/kamailio: refactoring - improved options handling - improved building - fixed plist PR: 240206 Submitted by: Dmitry Wagin <dmitry.wagin@ya.ru> Changes: head/net/kamailio/Makefile head/net/kamailio/files/kamailio.in head/net/kamailio/files/patch-src_Makefile head/net/kamailio/files/patch-src_Makefile.defs head/net/kamailio/files/patch-src_main.c head/net/kamailio/files/patch-src_modules_ctl_ctl.c head/net/kamailio/files/patch-src_modules_ctl_ctl__defaults.h head/net/kamailio/files/patch-src_modules_tls_Makefile head/net/kamailio/files/patch-src_modules_tls_tls__bio.c head/net/kamailio/files/patch-utils_kamctl_Makefile head/net/kamailio/pkg-plist |
Created attachment 207021 [details] kamailio.diff - improved options handling - improved building - fixed plists