|Summary:||ports-mgmt/portlint: Bogus "Restrictive licensing found." error is printed|
|Product:||Ports & Packages||Reporter:||Yuri Victorovich <yuri>|
|Component:||Individual Port(s)||Assignee:||Joe Marcus Clarke <marcus>|
|Severity:||Affects Only Me||Flags:||bugzilla:
Description Yuri Victorovich 2019-08-31 16:50:35 UTC
Testcase: net/opennx rev. 510400 > $ portlint -C > WARN: Makefile: Restrictive licensing found. Do not forget to update ports/LEGAL. > WARN: Makefile: NO_PACKAGE is obsolete. It should be replaced with "LICENSE_PERMS=no-pkg-mirror" > 0 fatal errors and 2 warnings found. NO_PACKAGE=xx doesn't mean that licensing is restrictive.
Comment 1 Kubilay Kocak 2019-09-01 22:40:10 UTC
If there are conditions under which contributors are 'required' to update LEGAL, then those conditions should be: - Exact (no FP's, not interpretive) - Explained/mentioned explicitly in the message
Comment 2 Joe Marcus Clarke 2019-09-02 14:29:29 UTC
I have modified the wording slightly. Since portlint can't know the scope of every license, I've made this more subjective on the committer: "Possible restrictive licensing found. If there are, in fact, limitations to use or distribution, please update ports/LEGAL."
Comment 3 commit-hook 2019-09-04 15:08:04 UTC
A commit references this bug: Author: marcus Date: Wed Sep 4 15:07:48 UTC 2019 New revision: 511098 URL: https://svnweb.freebsd.org/changeset/ports/511098 Log: Update to 2.18.10. * Relax wording around restrictive licensing  * Remove the check for extra items in the USE/USES section  One is allowed to put any _related_ variables here, and this will always change. It's easier not to check than to provide wrong recommendations. * Fix the check for unspecified license files  PR: 240233  239045  231303  Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/src/portlint.pl
Comment 4 Joe Marcus Clarke 2019-09-04 15:08:35 UTC
Relaxed wording in 2.18.10.