Bug 240353

Summary: [NEW PORT] sysutils/bmfdec: Decompile binary MOF file (BMF) from WMI buffer
Product: Ports & Packages Reporter: Norikatsu Shigemura <nork>
Component: Individual Port(s)Assignee: Mateusz Piotrowski <0mp>
Status: Closed FIXED    
Severity: Affects Only Me CC: 0mp, koobs, takawata
Priority: --- Keywords: feature, patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://reviews.freebsd.org/D21529
Attachments:
Description Flags
A shell archiver for bmfdec port. none

Description Norikatsu Shigemura 2019-09-05 14:19:21 UTC
Created attachment 207215 [details]
A shell archiver for bmfdec port.

Add a new port to decompile binary MOF file from WMF buffer,
requested by takawata@FreeBSD.org.

Now takawata@ implemented WMI embedded Binary MOF object interface to acpi_wmi(4).
SEE ALSO: https://reviews.freebsd.org/D21529
Comment 1 Takanori Watanabe freebsd_committer freebsd_triage 2019-09-06 10:26:13 UTC
FYI, the driver has been commited.
https://svnweb.freebsd.org/changeset/base/351930
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-06 10:43:08 UTC
Assign to committer that requested port, also MAINTAINER.

Review items: 

Recommend using 0.0.0.g20180113 (note the extra zero) as PORTVERSION, or just tag 0.0.1 in the repository and use that for GH_TAGNAME (this is better).

Please include the port addition to sysutils/Makefile
 
The changes look fine, I'm happy to approve them (ports) with confirmation that QA (portlint, poudriere) passes.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-06 10:43:43 UTC
Back over to Mateusz, who self-assigned
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-09-06 10:47:01 UTC
Takanori, are you fine with becoming the maintainer of this port?
Comment 5 Takanori Watanabe freebsd_committer freebsd_triage 2019-09-06 10:58:10 UTC
Agree.
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-09-06 10:58:25 UTC
Let me know if it looks fine for you:
https://reviews.freebsd.org/D21545
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-09-06 12:59:14 UTC
A commit references this bug:

Author: 0mp
Date: Fri Sep  6 12:58:26 UTC 2019
New revision: 511316
URL: https://svnweb.freebsd.org/changeset/ports/511316

Log:
  New port: converters/bmfdec: Decompile binary MOF file (BMF) from WMI buffer

  Binary MOF buffer in WMI tools:
  * Decompile binary MOF file (BMF) to UTF-8 plain text MOF file.
  * Decompress binary MOF file (BMF)
  * Parse binary MOF file (BMF)

  EXAMPLES:
   sysctl -b dev.acpi_wmi.0.bmof | bmf2mof

  SEE ALSO:
   acpi_wmi(4)

  WWW: https://github.com/pali/bmfdec/

  PR:		240353
  Submitted by:	<nork ninth-nine com> (previous version)
  Reviewed by:	takawata
  Differential Revision:	https://reviews.freebsd.org/D21545

Changes:
  head/converters/Makefile
  head/converters/bmfdec/
  head/converters/bmfdec/Makefile
  head/converters/bmfdec/distinfo
  head/converters/bmfdec/pkg-descr
Comment 8 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-09-06 12:59:38 UTC
Thanks!