Summary: | ports-mgmt/portlint: Comments in sections (eg: USES/LICENSE) throws FATAL false positives | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Kubilay Kocak <koobs> |
Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | Keywords: | needs-patch, needs-qa |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(marcus) |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
Kubilay Kocak
2019-09-06 07:11:51 UTC
Forgot to note, in case it helps with analysis or a fix, removing any *one* of the comments results in expected behaviour: looks fine. So there's a parsing instruction that merges <comment><blank line><comment> into one section. Essentially, this is pulling up USES into LICENSE. This is a commented part of the code, so at some point someone wanted this. I'm removing the parsing for now to see who complains. A commit references this bug: Author: marcus Date: Mon Mar 2 22:23:11 UTC 2020 New revision: 527653 URL: https://svnweb.freebsd.org/changeset/ports/527653 Log: Update to 2.18.11 * No longer warn for manpages installed under share/man [1] * Remove code to combine comments and blank lines in a section [2] * Remove code to combine comments and blank lines [3] * USE_PYQT sets the necessary QT USES [4] * Only warn on lack of INSTALLS_ICONS when USES=gnome is set [5] * Check for files that have been patched multiple times [6] PR: 240359 [2] 244480 [3] 240445 [4] 244039 [5] 243600 [6] Submitted by: 0mp [1] [5] vladimir.chukharev@gmail.com [4] swills [6] Differential Revision: D23896 [1] Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/src/portlint.pl Fixed in 2.18.11. |