Bug 240445

Summary: ports-mgmt/portlint: PYQT-related false positives
Product: Ports & Packages Reporter: vladimir.chukharev
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (marcus)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch vladimir.chukharev: maintainer-approval?

Description vladimir.chukharev 2019-09-09 13:44:13 UTC
Created attachment 207325 [details]
Patch

Hi,

portlint gives false positives about PYQT related variables. This can be seen with the following.
$ ( cd /usr/ports/graphics/py-traitsui ; portlint -Ca )
WARN: Makefile: When USES=pyqt:5 is defined, you must also define USE_PYQT=xxxx
0 fatal errors and 1 warning found.

A discussion can found at https://reviews.freebsd.org/D21229 .

I propose a patch adding USE_PYQT to @varlist and checking $makevar if static text analysis does not find the variable. This fixes the bug for me, but you better carefully test the patch, since I do not use Perl myself.

The patch also bumps the port version, sorry if that disturbs...

QA:
port test : OK
poudriere : OK
portlint -Ca: OK

Vladimir
Comment 1 Joe Marcus Clarke freebsd_committer 2020-03-02 22:24:03 UTC
Committed to 2.18.11, thanks.