Bug 240484

Summary: databases/mysql-connector-odbc build failure for mysql56
Product: Ports & Packages Reporter: tech-lists
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Only Me CC: danfe, w.schwarzenfeld
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
svn-diff-mysql-connector-odbc none

Description tech-lists 2019-09-11 00:26:56 UTC 
Hello,

context: freebsd-12-stable / amd64

poudriere-devel testport fails for databases/mysql-connector-odbc when built for mysql56

error:

[00:01:27] FAILED: driver/CMakeFiles/myodbc5a.dir/dll.cc.o 
[00:01:27] /ccache/libexec/ccache/c++  -DDBUG_OFF -DDISABLE_ALL_PSI -DHAVE_LIBDL -DHAVE_LPCWSTR -DTHREAD -DUSE_SQLCOLATTRIBUTE_SQLLEN_PTR -DUSE_SQLPARAMOPTIONS_SQLULEN_PTR -DUSE_UNIXODBC -D_UNIX_ -Dmyodbc5a_EXPORTS -I/usr/local/include/mysql -I/usr/local/include -I/wrkdirs/usr/ports/databases/mysql-connector-odbc/work/mysql-connector-odbc-5.3.13-src -I/wrkdirs/usr/ports/databases/mysql-connector-odbc/work/mysql-connector-odbc-5.3.13-src/driver/../util -O2 -pipe -march=haswell -fstack-protector-strong -fno-strict-aliasing -std=c++0x -O2 -pipe -march=haswell -fstack-protector-strong -fno-strict-aliasing -fPIC    -I/usr/local/include/mysql -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -g -fno-omit-frame-pointer -fno-strict-aliasing -w -MD -MT driver/CMakeFiles/myodbc5a.dir/dll.cc.o -MF driver/CMakeFiles/myodbc5a.dir/dll.cc.o.d -o driver/CMakeFiles/myodbc5a.dir/dll.cc.o -c /wrkdirs/usr/ports/databases/mysql-connector-odbc/work/mysql-connector-odbc-5.3.13-src/driver/dll.cc
[00:01:27] /wrkdirs/usr/ports/databases/mysql-connector-odbc/work/mysql-connector-odbc-5.3.13-src/driver/dll.cc:128:5: error: use of undeclared identifier 'my_thread_end_wait_time'
[00:01:27]     my_thread_end_wait_time= 0;
[00:01:27]     ^
[00:01:27] 1 error generated.
[00:01:27] ninja: build stopped: subcommand failed.
[00:01:27] *** Error code 1
[00:01:27] 
[00:01:27] Stop.
[00:01:27] make: stopped in /usr/ports/databases/mysql-connector-odbc
[00:01:31] Saved databases/mysql-connector-odbc | mysql-connector-odbc-unixodbc-mysql56-5.3.13_1 wrkdir to: /wd/poudriere/data/wrkdirs/12S-localhost-default/default/mysql-connector-odbc-unixodbc-mysql56-5.3.13_1.txz
[00:01:31] build of databases/mysql-connector-odbc | mysql-connector-odbc-unixodbc-mysql56-5.3.13_1 ended at Wed Sep 11 01:20:09 BST 2019
[00:01:31] build time: 00:00:19
[00:01:31] !!! build failure encountered !!!
[00:01:31] Error: Build failed in phase: build
[00:01:31] Cleaning up
[00:01:32] Unmounting file systems
Comment 1 tech-lists 2019-09-11 00:29:02 UTC 
the jail version info is: 12.0-STABLE 1200515 r351362  amd64
Comment 2 Walter Schwarzenfeld 2019-09-11 03:21:59 UTC 
Created attachment 207367 [details]
svn-diff-mysql-connector-odbc

Try this.
Comment 3 tech-lists 2019-10-11 04:42:40 UTC 
(In reply to Walter Schwarzenfeld from comment #2)

Hi, (sorry for the delay)

your patch fixed it! 

Many thanks,
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-15 10:12:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3146d8194eb3ec694d6473d1eac38de1b4a3e7a

commit b3146d8194eb3ec694d6473d1eac38de1b4a3e7a
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-07-15 10:10:36 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-07-15 10:10:55 +0000

    databases/mysql-connector-odbc: unbreak the build against MySQL <5.7.

    PR:     240484

 .../mysql-connector-odbc/files/patch-driver_dll.cc (new)      | 11 +++++++++++
 .../mysql-connector-odbc/files/patch-driver_handle.cc (new)   | 11 +++++++++++
 2 files changed, 22 insertions(+)