Bug 240568

Summary: graphics/argyllcms: update to 2.1.1
Product: Ports & Packages Reporter: Walter Schwarzenfeld <w.schwarzenfeld>
Component: Individual Port(s)Assignee: Koop Mast <kwm>
Status: New ---    
Severity: Affects Only Me CC: fixer, greg, mi, w.schwarzenfeld
Priority: --- Flags: bugzilla: maintainer-feedback? (kwm)
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
Do not extract zlib and other bundled libraries
argyll.patch - 2.1.2 none

Description Walter Schwarzenfeld freebsd_triage 2019-09-13 18:35:53 UTC
Created attachment 207471 [details]

Update argyllcms to 2.1.1.
Switch to gcc (clang does not build the files in the spectro directory).

Found no ChangeLog. The Readme files in the source tells it is mostly a bugfix for icc.
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-09-13 18:36:28 UTC
Also tested build with colord, builds fine.
Comment 2 Walter Schwarzenfeld freebsd_triage 2019-09-13 19:59:19 UTC
Created attachment 207475 [details]

Little change cause of portlint.
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-09-13 20:16:52 UTC
Created attachment 207476 [details]

Was an error in.
Comment 4 Mikhail Teterin freebsd_committer 2020-03-31 04:05:47 UTC
Created attachment 212881 [details]
Do not extract zlib and other bundled libraries

Thanks for the submission, Walter. Would you care to update it to 2.1.2, released in January?

Independently, I have this little patch, which prevents the bundled sources for zlib, png, tiff, and jpeg from even being extracted.

This not only saves space at build-time -- the current version (1.9.2) actually compiles the bundled zlib, even if it does not use it! It may well be the case with the 2.1.x versions too...

I wish, yajl and mxml could be similarly excluded, but Argyll has made changes to them, which aren't in their respected upstreams :-(
Comment 5 Greg V 2020-04-11 11:33:51 UTC
Created attachment 213279 [details]
argyll.patch - 2.1.2

Here's 2.1.2 (with the extract patch from above), gcc was not required for me (llvm10 worked fine). Had to add an extra -L flag for LOCALBASE.