Bug 240596

Summary: audio/mhwaveedit: Fails to build with PULSEAUDIO=on
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People Keywords: needs-patch
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   

Description Jan Beich freebsd_committer 2019-09-15 22:09:01 UTC
$ make WITH=PULSEAUDIO
[...]
In file included from sound.c:76:
./sound-pulse.c:1066:6: error: unknown type name 'Intbox'
     Intbox *pblat;
     ^
./sound-pulse.c:1072:10: warning: implicit declaration of function 'intbox_check_limit' is invalid in C99 [-Wimplicit-function-declaration]
     if (intbox_check_limit(up->pblat,0,10000,_("playback latency")))
         ^
./sound-pulse.c:1099:10: warning: implicit declaration of function 'intbox_new' is invalid in C99 [-Wimplicit-function-declaration]
     d = intbox_new(inifile_get_guint32("pulseLatency",0));
         ^
./sound-pulse.c:1099:8: warning: incompatible integer to pointer conversion assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'int' [-Wint-conversion]
     d = intbox_new(inifile_get_guint32("pulseLatency",0));
       ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./sound-pulse.c:1100:18: warning: implicit declaration of function 'INTBOX' is invalid in C99 [-Wimplicit-function-declaration]
     up->pblat = INTBOX(d);
                 ^
4 warnings and 1 error generated.
Comment 1 commit-hook freebsd_committer 2019-09-16 21:13:43 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Sep 16 21:12:49 UTC 2019
New revision: 512190
URL: https://svnweb.freebsd.org/changeset/ports/512190

Log:
  - Fix build with PULSEAUDIO (see also https://github.com/magnush/mhwaveedit/pull/13)
  - Add missing USES=gnome

  PR:		240596
  Reported by:	jbeich@FreeBSD.org

Changes:
  head/audio/mhwaveedit/Makefile
  head/audio/mhwaveedit/files/
  head/audio/mhwaveedit/files/patch-src_sound-pulse.c