Bug 240621
| Summary: | Flakey test case: lib.libc.sys.stat_test.stat_socket | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Li-Wen Hsu <lwhsu> |
| Component: | tests | Assignee: | Mark Johnston <markj> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | emaste, markj, ngie |
| Priority: | --- | ||
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Li-Wen Hsu
2019-09-17 02:17:12 UTC
A commit references this bug: Author: lwhsu Date: Tue Sep 17 14:08:09 UTC 2019 New revision: 352448 URL: https://svnweb.freebsd.org/changeset/base/352448 Log: Temporarily skip flakey test case lib.libc.sys.stat_test.stat_socket PR: 240621 Sponsored by: The FreeBSD Foundation Changes: head/contrib/netbsd-tests/lib/libc/sys/t_stat.c I'm not sure how this test is expected to (consistently) work. It does a O_NONBLOCK connect(2) to 127.0.0.1:42 and requires that errno is EINPROGRESS. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=95c75073d3d1ca9dcae41784453172f199bb2c0f commit 95c75073d3d1ca9dcae41784453172f199bb2c0f Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2022-01-14 20:00:01 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-01-14 20:01:41 +0000 netbsd-tests: Fix the libc stat_socket test The test tries to connect a socket to a closed port at 127.0.0.1. It sets O_NONBLOCK on the socket first and expects to get EINPROGRESS from connect(2), but this is not guaranteed, ECONNREFUSED is possible. Handle both cases, and re-enable the test. PR: 240621 MFC after: 1 week Sponsored by: The FreeBSD Foundation contrib/netbsd-tests/lib/libc/sys/t_stat.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=812345b1d469e5bb90f5487fef1e4ab16890cc7a commit 812345b1d469e5bb90f5487fef1e4ab16890cc7a Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2022-01-14 20:00:01 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-01-21 00:52:36 +0000 netbsd-tests: Fix the libc stat_socket test The test tries to connect a socket to a closed port at 127.0.0.1. It sets O_NONBLOCK on the socket first and expects to get EINPROGRESS from connect(2), but this is not guaranteed, ECONNREFUSED is possible. Handle both cases, and re-enable the test. PR: 240621 Sponsored by: The FreeBSD Foundation (cherry picked from commit 95c75073d3d1ca9dcae41784453172f199bb2c0f) contrib/netbsd-tests/lib/libc/sys/t_stat.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=9f192dd79cce2ea53a1cdc3ab64ea204a2fb9d84 commit 9f192dd79cce2ea53a1cdc3ab64ea204a2fb9d84 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2022-01-14 20:00:01 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-01-21 00:53:44 +0000 netbsd-tests: Fix the libc stat_socket test The test tries to connect a socket to a closed port at 127.0.0.1. It sets O_NONBLOCK on the socket first and expects to get EINPROGRESS from connect(2), but this is not guaranteed, ECONNREFUSED is possible. Handle both cases, and re-enable the test. PR: 240621 Sponsored by: The FreeBSD Foundation (cherry picked from commit 95c75073d3d1ca9dcae41784453172f199bb2c0f) contrib/netbsd-tests/lib/libc/sys/t_stat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) *** Bug 219875 has been marked as a duplicate of this bug. *** |