Bug 240631

Summary: www/p5-WWW-Curl: Fix build on GCC architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Some People CC: sunpoet
Priority: --- Keywords: needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (sunpoet)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (sunpoet), koobs: maintainer-approval+

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-09-17 09:23:35 UTC
Created attachment 207553 [details]
patch

When building with GCC:
Curl.xs:76: error: expected '{' before 'void'

Remove "struct" to fix build.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-17 09:26:18 UTC
This should be sent upstream
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-17 09:27:11 UTC
Comment on attachment 207553 [details]
patch

@Piotr Build fixes are:

Approved by: portmgr (blanket: build fix)
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2019-09-17 17:24:37 UTC
Mentor approval (pending maintainer review): builds on ppcports.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-09-25 20:55:18 UTC
A commit references this bug:

Author: sunpoet
Date: Wed Sep 25 20:55:02 UTC 2019
New revision: 512855
URL: https://svnweb.freebsd.org/changeset/ports/512855

Log:
  Fix build on powerpc

  PR:		240631
  Submitted by:	pkubaj

Changes:
  head/www/p5-WWW-Curl/files/patch-Curl.xs
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-09-25 20:56:15 UTC
Committed. Thanks!