Bug 240664
| Summary: | devel/awscli: Use mandoc instead of groff for DOCS and suggest auto-complete | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Norikatsu Shigemura <nork> | ||||||||
| Component: | Individual Port(s) | Assignee: | Bradley T. Hughes <bhughes> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | pete | ||||||||
| Priority: | --- | Keywords: | easy, needs-qa | ||||||||
| Version: | Latest | Flags: | bhughes:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Thank you for the report and patch. Is there a chunk missing for pkg-message to "display how to auto-complete." ? Created attachment 207604 [details]
awscli's patch file
Oops, sorry. I forgot svn add files/pkg-message.in.
Created attachment 207607 [details]
awscli's patch file
I rewrote awscli/help.py's patch.
Because I'll pull-request to upstream.
This is a very nice change. The groff run-time dependency is heavy, and I would happily change it to use mandoc. Upstreaming this change would be a good idea, too, and if you haven't already, I will happily do so. Thanks for the patches, I'll start getting them ready for commit now :) Thank you. I pull-requested to upstream, but .... https://github.com/aws/aws-cli/pull/4505 A commit references this bug: Author: bhughes Date: Wed Sep 25 19:02:11 UTC 2019 New revision: 512804 URL: https://svnweb.freebsd.org/changeset/ports/512804 Log: devel/awscli: use mandoc instead of groff, suggest auto-complete Add patch from PR 240664 to use mandoc instead of groff, and remove the DOCS option and runtime dependency on groff. Bump PORTREVISION due to the change in package dependencies. While here, add pkg-message with instructions on how to enable auto- complete for awscli. PR: 240664 Submitted by: nork@ninth-nine.com Sponsored by: Miles AS Changes: head/devel/awscli/Makefile A commit references this bug: Author: bhughes Date: Wed Sep 25 19:06:05 UTC 2019 New revision: 512805 URL: https://svnweb.freebsd.org/changeset/ports/512805 Log: devel/awscli: add files missing from r511778 PR: 240664 Submitted by: nork@ninth-nine.com Sponsored by: Miles AS Changes: head/devel/awscli/files/ head/devel/awscli/files/patch-awscli_help.py head/devel/awscli/files/pkg-message.in Committed, thanks for the patch! :) |
Created attachment 207600 [details] awscli's patch file 'aws help' required groff, but it's toooo big dependencies for 'help'. I wrote a simple patch using mandoc(1) instead of groff(1). So no dependency on textprof/groff. And, I feel unkindness to use auto-complete for awscli, I think that should be display how to auto-complete.