Bug 240736
| Summary: | [NEW PORT] astro/py-ephem: Compute positions of the planets and stars | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Rainer Hurling <rhurlin> | ||||||
| Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | db, python, rhurlin, wen | ||||||
| Priority: | --- | Keywords: | feature | ||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
koobs: merge-quarterly+ |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 240735 | ||||||||
| Attachments: |
|
||||||||
|
Description
Rainer Hurling
2019-09-21 17:35:21 UTC
A patch to change astro/pyephem to take astro/py-ephem as a dependency was submitted in bug #240736 Sorry, of course I mean this PR: A patch to change astro/pyephem to take astro/py-ephem as a dependency was submitted in bug #240735 Take this to understand the rename and figure out the best strategy (In reply to Kubilay Kocak from comment #3) Would astro/py-ephem repocopied from astro/pyephem ? wen (In reply to Wen Heping from comment #4) No, I think it is better to use the attached shar file. This port is new and slightly different from the predecessor (no port epoch, comment, no post-install). What is unclear to me is, if category hamradio should be mentioned and if you, Wen, would like to be the maintainer again. As said before, this would be ok for me, of course. (In reply to Rainer Hurling from comment #5) It is better you maintain this new port. Thank you ! wen Summarise: - pyphem was renamed to ephem upstream - pyphem is now a empty stub package, that depends on ephem (upstream) - This issue creates the new (ephem) port - Bug 240735 updates pychem to depend on ephem (after the new port lands) @Rainer If you could produce and attach a diff based on an svn copy of astro/pyechem -> astro/py-echem that would be much appreciated I have additional comments/questions to add in bug 240735, and will them follow up here again if necessary -- ^Triage: Canonicalize summary: New ports are "[NEW PORT} cat/port: COMMENT" There is sufficient background/explanation in comment 0, not to have to describe that rationale in the summary Created attachment 209701 [details] diff based on svn copy astro/pyephem -> astro/py-ephem @Kubilay Your summarize seems correct to me (except small typo 'pyphem' instead of pyephem). If my understanding is right, after the update the only task left for the old port, astro/pyephem, is to ensure the 'new' port, astro/py-ephem, is installed ... Don't now, if the attached patch is, what you want to have? Answering your issues in bug #240735, comment #5 needs more time. I will try to investigate ... Are we good to go now? This is blocking gnuradio. (In reply to Diane Bruce from comment #9) Hi Diane, As pointed out, this port is meant as the functional follow up of astro/pyephem (bug #240735), which is only a stub now, with no functional content. Kubilay asked some questions in bug #240735. I will try to answer in the near next time. Review items (already taken care of in WIP): - Add LICENSE_FILE where one is provided in the source distribution - Add missing python (virtual) category to CATEGORIES - Add test command to run test suite where one is available A commit references this bug: Author: koobs Date: Sun Dec 15 09:24:45 UTC 2019 New revision: 520162 URL: https://svnweb.freebsd.org/changeset/ports/520162 Log: [NEW PORT] astro/py-ephem: Compute positions of the planets and stars PyEphem provides an ephem Python package for performing high-precision astronomy computations. The underlying numeric routines are coded in C and are the same ones that drive the popular XEphem astronomy application, whose author, Elwood Charles Downey, generously gave permission for their use in PyEphem. The name ephem is short for the word ephemeris, which is the traditional term for a table giving the position of a planet, asteroid, or comet for a series of dates. WWW: https://rhodesmill.org/pyephem/ WWW: https://pypi.org/project/ephem/ [1] Based on astro/pyephem PR: 240736 Submitted by: Rainer Hurling <rhurlin gwdg de> MFH: 2019Q4 (required for fixing pyephem, unbreaking gnuradio et al) Changes: head/astro/Makefile head/astro/py-ephem/ head/astro/py-ephem/Makefile head/astro/py-ephem/distinfo head/astro/py-ephem/files/ head/astro/py-ephem/files/patch-setup.py head/astro/py-ephem/pkg-descr (In reply to commit-hook from comment #12) Hi Koobs, Thanks for the commit. Only one question: Why did you change to 'db' as author (Created by) in the first line? (In reply to Rainer Hurling from comment #13) You're welcome :) I didn't, since the py-ephem port was based on (an svn copy of) pyephem, that's the line it had, and it would be less correct to change it (given the ports history) (In reply to Kubilay Kocak from comment #14) OK, I understand. Of course, that's correct and fine! Thanks for clarification. (In reply to Rainer Hurling from comment #15) My pleasure :) I'll close this and related issues once MFH'd, and all the affected (broken) ports are fixed. (In reply to Rainer Hurling from comment #15) I will add the "Created by" was a now obsolete requirement and had I been committing the port I would have removed the line as superfluous. (In reply to Diane Bruce from comment #17) Hi Diane, I have no problem with this 'Created by' line. I was only wondering, where it came from ... ;) Best wishes, Rainer DH6BAG (In reply to Diane Bruce from comment #17) While I love crediting contributors, I'm personally +o on Created By: removals in ports, and believe we should find better more effective/visible ways of crediting and showcasing our contributor base At this point however, the defacto guideline is: - Removal by request/approval is OK, otherwise leave in place *thought* I might start removing all of my 'Created by:'s to encourage others. A commit references this bug: Author: koobs Date: Fri Dec 20 10:07:28 UTC 2019 New revision: 520492 URL: https://svnweb.freebsd.org/changeset/ports/520492 Log: MFH: r520162 [NEW] astro/py-ephem: Compute positions of the planets and stars PyEphem provides an ephem Python package for performing high-precision astronomy computations. The underlying numeric routines are coded in C and are the same ones that drive the popular XEphem astronomy application, whose author, Elwood Charles Downey, generously gave permission for their use in PyEphem. The name ephem is short for the word ephemeris, which is the traditional term for a table giving the position of a planet, asteroid, or comet for a series of dates. WWW: https://rhodesmill.org/pyephem/ WWW: https://pypi.org/project/ephem/ [1] Based on astro/pyephem PR: 240736 Submitted by: Rainer Hurling <rhurlin gwdg de> Approved by: ports-secteam (joneum) Changes: _U branches/2019Q4/ branches/2019Q4/astro/Makefile branches/2019Q4/astro/py-ephem/ |