Summary: | Upgrade x11/libXvMC to 1.0.12 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | pete | ||||||||||||
Component: | Individual Port(s) | Assignee: | freebsd-x11 (Nobody) <x11> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Some People | CC: | zeising | ||||||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(x11) |
||||||||||||
Version: | Latest | ||||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
Bug Depends on: | 241314 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
pete
2019-09-25 00:39:15 UTC
Created attachment 207782 [details]
diff to upgrade
Building now against 12.0-RELEASE and will update when build completes and I've had a chance to test it. Created attachment 207829 [details]
update diff for libXvMC
this includes fixes for the plist file which were missed in the original patch I submitted.
Created attachment 207830 [details]
update xorgproto plist to not manage vldXvMC
extensions/vldXvMC.h is now tracked by libXvMC and should no longer be managed by xorgproto.
Created attachment 207831 [details]
patch-Makefile.am
The intent of this is to be placed in x11/xorgproto/files/patch-Makefile.am. It should update xorgproto's Makefile.am to not create include/X11/extensions/vldXvMC.h.
For some reason I can not get this to work when I build on my systems, so I am posting this here hoping a fresh set of eyes can point out what I am doing wrong.
Created attachment 207832 [details]
updated diff for libXvMC
re-posting this attachment to ensure it is clear that it obsoletes the original patch I posted.
Is there any chance you can have libXvMC not provide the header for now? I worry that changing xorgproto to not include the header will cause issues with other ports. (In reply to Niclas Zeising from comment #7) Should have read Changelog earlier: "commit 0fab90b409a3e4848603bdb6b438523038239f23 Author: Adam Jackson <ajax@redhat.com> Date: Tue Sep 24 12:28:19 2019 -0400 vld: Provide <X11/extensions/vldXvMC.h> ourself This header refers to libX11 types, it doesn't belong in xorgproto and has been moved to legacy in 2019.2. Supply it ourselves." Of course there is no 2019.2 tag yet for xorgproto, so i think the best thing to do is put this PR on hold until xorgproto-2019.2 is released, then things should build cleanly. Yeah, I know the background for the move, but there is some time before xorgproto can be fixed, and moving this header might surprise some ports. (In reply to Niclas Zeising from comment #9) Looking at the diffs for this release, it seems the only change is to move this header into libXvMC, so I suggest we put this on hold until xorgproto is released, and then come up with a plan to get dependent ports updated as well. https://gitlab.freedesktop.org/xorg/lib/libxvmc/commits/libXvMC-1.0.12 (In reply to pete from comment #10) Agree A commit references this bug: Author: zeising Date: Wed Nov 6 17:58:30 UTC 2019 New revision: 516911 URL: https://svnweb.freebsd.org/changeset/ports/516911 Log: Update xorgproto, libX11 and libXvMC Update x11/xorgproto to 2019.2 [0] Disable all legacy headers, they are no longer needed, since they only detail deprecated protocol features. Update x11/libX11 to 1.6.9 This is a minor update, mostly containing fixes to work with updated x11/xorgproto. Update x11/libXvMC to 1.0.12 [1] This is a minor update, mostly containing fixes to work with updated x11/xorgproto. Patch mesa prts to explicitly link against -lXv, previously this was pulled in by x11/libXvMC, but with changes to libXvMC .pc file, this is no longer true. Bump portrevision for mesa-dri because of this. Thanks fo antoine for the exp-run! PR: 241314 (exp-run) [0], 240801 [1] Submitted by: pete@nomadlogic.org [1] Changes: head/graphics/mesa-dri/Makefile head/graphics/mesa-dri/files/patch-src_gallium_state__trackers_xvmc_Makefile.in head/graphics/mesa-dri/files/patch-src_gallium_targets_xvmc_Makefile.in head/x11/libX11/Makefile head/x11/libX11/distinfo head/x11/libX11/files/ head/x11/libX11/pkg-plist head/x11/libXvMC/Makefile head/x11/libXvMC/distinfo head/x11/libXvMC/pkg-plist head/x11/xorgproto/Makefile head/x11/xorgproto/distinfo head/x11/xorgproto/pkg-plist Comitted, thanks! |