Bug 240979
| Summary: | multimedia/gstreamer1-libav: remove -mminimal-toc on powerpc64 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-multimedia (Nobody) <multimedia> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | linimon, multimedia | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(multimedia) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Can you check if FFMPEG=off builds? ports r479994 added the line when FFMPEG was not in OPTIONS_DEFAULT. Otherwise, removing arch-specific quirks can be done under portmgr blanket. It doesn't build with FFMPEG=off, but because of: libavcodec/ppc/hevcdsp.c:60: error: argument 1 must be a 5-bit signed literal I suppose USES=compiler:c11 would fix it, but there's already USES=compiler:features. Since this is non-default option, I suppose we can just leave it as is. (In reply to Piotr Kubaj from comment #2) > I suppose USES=compiler:c11 would fix it, but there's already > USES=compiler:features. Then replace USES=compiler:features with USES=compiler:c11 because: # Mk/Uses/compiler.mk .if ${_COMPILER_ARGS:Mc++*} || ${_COMPILER_ARGS:Mc11} _COMPILER_ARGS+= features .endif > Since this is non-default option, I suppose we can just leave it as is. gstreamer1-libav is often non-trivial to unbreak during major ffmpeg updates (e.g., 3.* -> 4.0), so the option is used as an interim fix. If -mminimal-toc is still required convert to # Place after _MAKE_ENV FFMPEG_CFLAGS_OFF= ${"${ARCH:Mpowerpc64}":?-mminimal-toc:} I can confirm that the port builds for me with the patch, but only tested with the default options. Doesn't build with GCC9 as well (FFMPEG=off): /usr/local/bin/as -I. -I./ -isystem /usr/local/include -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DPIC -DZLIB_CONST -fPIC -g -c -o libavcodec/ppc/fft_altivec.o lib avcodec/ppc/fft_altivec.S /usr/local/bin/as: unrecognized option `-isystem' A commit references this bug: Author: pkubaj Date: Wed Nov 20 13:41:32 UTC 2019 New revision: 518010 URL: https://svnweb.freebsd.org/changeset/ports/518010 Log: multimedia/gstreamer1-libav: remove -mminimal-toc The port now builds fine on elfv1 without it and it breaks build on elfv2. PR: 240979 Approved by: linimon (mentor), multimedia (maintainer timeout) Changes: head/multimedia/gstreamer1-libav/Makefile |
Created attachment 207992 [details] patch It's not needed anymore, the port builds.