Bug 241194

Summary: math/gfan: fix build on 13.0-CURRENT
Product: Ports & Packages Reporter: Lorenzo Salvadore <salvadore>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: needs-qa
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
gfan - fix on 13.0-CURRENT salvadore: maintainer-approval+

Description Lorenzo Salvadore freebsd_committer freebsd_triage 2019-10-11 11:22:47 UTC 
Created attachment 208243 [details]
gfan - fix on 13.0-CURRENT

At the moment gfan is broken on 13.0-CURRENT. Apparently this is due to a conflict between the definition of log2 in math.h and the definition of log2 in gfan's sources: the patch I propose should fix this issue.


See the following links for the actual errors:

http://beefy17.nyi.freebsd.org/data/head-i386-default/p514206_s353378/logs/gfan-0.6.2_1.log
http://beefy18.nyi.freebsd.org/data/head-amd64-default/p514206_s353378/logs/gfan-0.6.2_1.log

-------------------

I tested successfully the patch with poudriere on {11.3,12.0}-RELEASE {i386,amd64}. Of course it needs to be tested on 13.0-CURRENT, but unfortunately I am unable to do so: I run 12.1-STABLE and cannot run 13.0-CURRENT jails, while virtualization is quite difficult for my old and slow hardware. Then I ask if someone else can please test it.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-10-15 16:06:42 UTC 
A commit references this bug:

Author: swills
Date: Tue Oct 15 16:05:43 UTC 2019
New revision: 514542
URL: https://svnweb.freebsd.org/changeset/ports/514542

Log:
  math/gfan: fix build on 13.0-CURRENT

  PR:		241194
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch> (maintainer)

Changes:
  head/math/gfan/Makefile
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-10-15 16:06:52 UTC 
Committed, thanks!