Bug 241197
| Summary: | games/pioneer: Update to 20191009 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | lightside <lightside> | ||||||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | Keywords: | patch | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
lightside
2019-10-11 12:37:58 UTC
(In reply to lightside from comment #0) > - Add USES+=gnome and INSTALLS_ICONS=yes [4] Maybe not a good idea, see review D2907, bug 223498, bug 231122. Created attachment 208294 [details] Proposed patch with CACHE_ICONS port's option (since 512079 revision) (In reply to Jan Beich from comment #1) > Maybe not a good idea, see review D2907, bug 223498, bug 231122. This is not a Qt or GTK+ application, but there is installation of icons to ${LOCALBASE}/share/icons/hicolor directory, related to misc/hicolor-icon-theme port, which "provides a shared high-color desktop icon theme shell for use under both KDE and GNOME desktops.". This is understandable, that for Qt/KDE only environment there is not need usage of gtk-update-icon-cache utility (installed by graphics/gtk-update-icon-cache port), but for GTK+ environment this is needed to properly show icon(s) for ${LOCALBASE}/share/applications/net.pioneerspacesim.Pioneer.desktop. Moreover, the INSTALLS_ICONS=yes maybe needed for possibly mixed Qt and GTK+ environment. For example, (independent) usage of x11-fm/caja, which may properly show icon(s) for *.desktop file(s), if their (hicolor) icons was cached with using gtk-update-icon-cache utility. This may lead to some guess about that INSTALLS_ICONS=yes maybe not needed for KDE only ports/applications, but even in this case someone maybe interested to use their hicolor icons for mixed Qt and GTK+ environment. A possible solution is to provide a choose for user about usage of INSTALLS_ICONS=yes (or gtk-update-icon-cache utility). Otherwise, the ${LOCALBASE}/share/applications/net.pioneerspacesim.Pioneer.desktop may show empty icon for GTK+ environment. If user want to fix this, there is a need for manual usage of gtk-update-icon-cache utilty after (de)installation of games/pioneer port or its (re)installation with using `make INSTALLS_ICONS=yes deinstall install clean` command. I proposed new patch with CACHE_ICONS port's option. I guess, the committer may decide about whether this port's option should be enabled by default or not. Created attachment 208295 [details]
Proposed patch with CACHE_ICONS port's option (since 512079 revision)
Attached correct patch.
A commit references this bug: Author: swills Date: Tue Oct 15 15:52:59 UTC 2019 New revision: 514541 URL: https://svnweb.freebsd.org/changeset/ports/514541 Log: games/pioneer: Update to 20191009 PR: 241197 Submitted by: lightside <lightside@gmx.com> (maintainer) Changes: head/games/pioneer/Makefile head/games/pioneer/distinfo head/games/pioneer/files/buildopts.h head/games/pioneer/files/patch-src_scenegraph_Serializer.h head/games/pioneer/pkg-plist Committed, thanks! |
