Bug 241270

Summary: dns/opendnssec2: Unsupported extra_commands in rc.d service script.
Product: Ports & Packages Reporter: Ximon Eighteen <ximon>
Component: Individual Port(s)Assignee: Danilo G. Baio <dbaio>
Status: Closed FIXED    
Severity: Affects Only Me CC: dbaio, jaap
Priority: --- Flags: dbaio: maintainer-feedback+
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 250293    
Bug Blocks:    
Attachments:
Description Flags
Proposed alternate script content none

Description Ximon Eighteen 2019-10-15 14:00:11 UTC 
Hi,

The rc.d service script for OpenDNSSEC 2.x in the dns/opendnssec2 2.1.4_1 package [1] includes 'ksm' and 'reload' in the 'extra_commands' value. I believe these should be removed, because:

1. OpenDNSSEC 1.x had a 'ksm' component that was renamed to 'enforcer' in OpenDNSSEC 2.x. The 'dns/opendnssec2' package continues to reference [1] 'ksm' which is not a supported subcommand of ods-control [2] in OpenDNSSEC 2.x.

2. While the 'signer' and 'enforcer' subcommands support their own 'reload' subcommand, the 'ods-control' tool does NOT support a higher level 'reload' subcommand, e.g. 'ods-control signer reload' is possible but 'ods-control reload' will result in a usage error.

Thanks,

Ximon

References:
[1] https://svnweb.freebsd.org/ports/head/dns/opendnssec2/files/opendnssec.in?view=markup#l24
[2] https://github.com/opendnssec/opendnssec/blob/2.1.4/tools/ods-control.8.in
Comment 1 Ximon Eighteen 2019-10-22 12:09:31 UTC 
Created attachment 208507 [details]
Proposed alternate script content

Hi,

See attached proposed alternate script contents, either to be used, to assist with correcting the current script or to illuminate what perhaps needs to be done.

I'm not familiar with FreeBSD rc.d scripts so apologies if it is not suitable. I took a quick look at https://www.freebsd.org/doc/en_US.ISO8859-1/articles/rc-scripting/index.html but noted that OpenDNSSEC is not out-of-the-box compatible with the default expectations, e.g. pid files, status checking, thus I wrote custom functions to do the work.

Briefly tested on FreeBSD 12.0-RELEASE r341666 GENERIC in a VirtualBox VM.

Ximon
Comment 2 Jaap Akkerhuis 2020-10-12 10:19:08 UTC 
(In reply to Ximon Eighteen from comment #1)

Thanks for the script report and the fixed script!
It is now in fixed in the latest version, see bug #250293