Bug 241326
| Summary: | devel/psptoolchain-binutils: fix packaging on arm* | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | linimon, tphilipp | ||||||
| Priority: | --- | Flags: | tphilipp:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 208502 [details]
improved patch
Thanks for finding, this was indeed wrong as :C uses a regex, so armv* meant "0 or more v". Your fix works, but given it's a regex the "armv[6,7]" pattern would match "armv6", "armv," and "armv7".
So a more concise pattern would be simply "armv[67]", however I would go a step further and use "armv[0-9]+".
Find attached a slightly modified version of your patch that uses this pattern.
A commit references this bug: Author: pkubaj Date: Sat Nov 9 19:53:19 UTC 2019 New revision: 517143 URL: https://svnweb.freebsd.org/changeset/ports/517143 Log: devel/psptoolchain-binutils: fix packaging on arm* Fix CONFIGURE_TARGET on armv* to fix packaging. PR: 241326 Submitted by: tphilipp@potion-studios.com (maintainer) Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D22104 Changes: head/devel/psptoolchain-binutils/Makefile |
Created attachment 208404 [details] patch For some reason, :C/armv*/arm returns arm7 on armv7, which causes errors during packaging (it should return arm).