Bug 241327

Summary:

mail/roundcube: Broken NSC option

Product:

Ports & Packages

Reporter:

Tobias Kortkamp <tobik>

Component:

Individual Port(s)

Assignee:

Alex Dupre <ale>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

ale

Priority:

---

Flags:

bugzilla: maintainer-feedback? (ale)

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
roundcube.diff	tobik: maintainer-approval? (ale)

Description Tobias Kortkamp freebsd_committer

2019-10-18 13:54:57 UTC

Created attachment 208405 [details]
roundcube.diff

The NSC option has been basically broken in ports r423243 where 

.if ${PORT_OPTIONS:MNSC}
post-extract:
	...
.endif

has been replaced with

post-extract-NSC:
	...

which is not equivalent and wrong (note the missing -on suffix).

This was three years ago and the port has been updated multiple
times since then.  Is files/spellchecker.php still functional?
Should we fix the option or remove it (the attached patch remove it)?

Comment 1 commit-hook freebsd_committer

2019-10-21 08:36:37 UTC

A commit references this bug:

Author: ale
Date: Mon Oct 21 08:36:11 UTC 2019
New revision: 515090
URL: https://svnweb.freebsd.org/changeset/ports/515090

Log:
  Update to 1.3.10 release and fix NSC option [1].

  PR:		241327 [1]
  Submitted by:	tobik

Changes:
  head/mail/roundcube/Makefile
  head/mail/roundcube/distinfo