Bug 241348
| Summary: | [PATCH] devel/evdev-proto: add joystick.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> | ||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | antoine, rozhuk.im, wulf, x11, zeising | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(x11) antoine: exp-run+ |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 241237, 241351, 241353, 241354 | ||||||||||
| Attachments: |
|
||||||||||
LGTM, please bump port version to 5.3 too. Created attachment 208692 [details]
up to 5.3
Do we need to bump portrevision on users? (In reply to Niclas Zeising from comment #3) > Do we need to bump portrevision on users? devel/libevdev and devel/py-evdev should increment portrevision Should I update patch to increment devel/libevdev and devel/py-evdev portrevision? (In reply to rozhuk.im from comment #5) Yes and let's request an exp-run afterwards to make it happen this year. Created attachment 209220 [details]
v2
Same as previous patch with bumps for libevdev and py-evdev.
Assigning to portmgr for an exp-run. Let's see if anything breaks by providing linux/joystick.h Exp-run looks fine A commit references this bug: Author: tobik Date: Wed Nov 27 09:53:12 UTC 2019 New revision: 518490 URL: https://svnweb.freebsd.org/changeset/ports/518490 Log: devel/evdev-proto: Update to 5.3 There are currently 3 copies of joystick.h in the ports tree with more on the way. Provide it in evdev-proto instead to avoid adding more copies and to allow removing the existing ones. PR: 241348 Submitted by: rozhuk.im@gmail.com Reviewed by: wulf Approved by: portmgr (antoine) Exp-run by: antoine Changes: head/devel/evdev-proto/Makefile head/devel/evdev-proto/distinfo head/devel/libevdev/Makefile head/devel/py-evdev/Makefile Thanks! |
Created attachment 208429 [details] add joystick.h This include file requires for at least 5 ports: multimedia/kodi-addon-peripheral-joystick multimedia/kodi-addon-peripheral.joystick-devel sysutils/jstest-gtk devel/sdl12 eboard/Makefile:RUN_DEPENDS+= ${LOCALBASE}/include/linux/joystick.h:devel/linux-js - broken now, devel/linux-js - removed I will add PR to change this ports here.