Summary: | net/kea: Minor improvements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jose Luis Duran <jlduran> | ||||||||
Component: | Individual Port(s) | Assignee: | Koichiro Iwao <meta> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | apevnev, meta | ||||||||
Priority: | --- | Flags: | apevnev:
maintainer-feedback+
|
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Created attachment 208432 [details]
Minor improvements
This revision includes the renaming of "legacy" patch files.
Comment on attachment 208432 [details]
Minor improvements
Thanks for the patch!
looks fine with the exception of:
-DISTNAME= ${PORTNAME}-${ISCVERSION}
note that default is ${PORTNAME}-${PORTVERSION} and I have ${PORTNAME}-${ISCVERSION}, this is an important difference.
Created attachment 208483 [details] Minor improvements Addresses comment #2 (In reply to Jose Luis Duran from comment #3) Thanks! A commit references this bug: Author: meta Date: Fri Oct 25 12:46:21 UTC 2019 New revision: 515608 URL: https://svnweb.freebsd.org/changeset/ports/515608 Log: net/kea: Pet portlint, rclint Also, add patch to support colorized output for `keactl status`. PR: 241349 Submitted by: Jose Luis Duran <jlduran@gmail.com> Approved by: Andrey Pevnev <apevnev@me.com> (maintainer) Changes: head/net/kea/Makefile head/net/kea/files/kea.in head/net/kea/files/patch-Makefile.am head/net/kea/files/patch-src-bin-keactrl-Makefile.am head/net/kea/files/patch-src-lib-dhcpsrv-Makefile.am head/net/kea/files/patch-src_bin_keactrl_keactrl.in head/net/kea/pkg-plist Committed with minor change (did make makepatch), thanks! (In reply to Koichiro Iwao from comment #6) Thank you! Apparently `make makepatch` generates filenames with the the new syntax. The current files have the "legacy" syntax: patch-src-bin-keactrl-Makefile.am -> patch-src_bin_keactrl_Makefile.am patch-src-lib-dhcpsrv-Makefile.am -> patch-src_lib_dhcpsrv_Makefile.am (In reply to Jose Luis Duran from comment #7) I'll get those into the new syntax form during next kea version update, hate updating between versions for cosmetic stuff. Thanks! (In reply to Andrey Pevnev from comment #8) Great! |
Created attachment 208431 [details] Minor improvements - portlint - rclint kea.in - [PATCH] support colorized output for `keactrl status`