Bug 24136

Summary: sysinstall's install.cfg tryRTSOL and tryDHCP don't work
Product: Base System Reporter: gordont <gordont>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.2-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description gordont 2001-01-07 23:40:02 UTC
When creating a install.cfg for an unattended installation, I specified
tryRTSOL=NO so it wouldn't prompt me for IPv6 configuration of my
network interfaces. Unfortunately, it still prompted me for it. From
looking at the code, tryDHCP=NO would produce the same result.

Fix: Quick work around:
	Use tryRTSOL=ASDF or some other nonsensical value

Patch:
	I think this should do it. I wasn't able to rebuild it to check
	to see if it works, but the logic is there.
How-To-Repeat: 
Try an unattended install specifying tryRTSOL=NO. It will still prompt you
asking if you want to Configure IPv6 for your network interface.
Comment 1 glenn 2001-06-02 01:51:57 UTC
I just ran across the same bug.  I think that I found the more basic
problem.  In tcpip.c, the code that tests the value of tryDHCP (and
tryRTSOL) has the test backwards when checking for the "NO" value.  In
the code:
        if (!variable_cmp(VAR_TRY_DHCP, "YES") ||
            ((!variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you
want to try DHCP configuration of the interface?")))) {

should be
        if (!variable_cmp(VAR_TRY_DHCP, "YES") ||
            ((variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you
want to try DHCP configuration of the interface?")))) {

I think that this addresses the underlying problem.  (This also explains
why setting tryDHCP to anything besides "YES" or "NO" has the effect
expected for tryDHCP=NO.

    - Glenn Trewitt
Comment 2 jkh freebsd_committer freebsd_triage 2001-08-31 20:57:39 UTC
State Changed
From-To: open->closed

Related bug fixed.