Bug 241361

Summary: databases/db5, databases/db6: Hook up DEBUG options helpers
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Matthias Andree <mandree>
Status: Closed FIXED    
Severity: Affects Only Me CC: mandree
Priority: --- Flags: mandree: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
db.diff mandree: maintainer-approval+

Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-20 09:14:53 UTC
Created attachment 208451 [details]
db.diff

It's just dangling there at the moment for no reason that I can see.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2019-10-20 22:03:56 UTC
do we expose everything as option? Do we need to add it explicitly? We don't need to list DOCS either, for instance. Will check in more depth another day.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-20 22:09:28 UTC
> We don't need to list DOCS either

Of course we need to.  You are confusing OPTIONS_DEFINE with OPTIONS_DEFAULT.
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2019-10-21 18:18:10 UTC
I rather thought I'd had it somewhere but don't care enough to dig up the history. I am testing the builds and will commit in a moment.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-10-21 18:21:20 UTC
A commit references this bug:

Author: mandree
Date: Mon Oct 21 18:21:14 UTC 2019
New revision: 515117
URL: https://svnweb.freebsd.org/changeset/ports/515117

Log:
  databases/db5, databases/db6: Hook up DEBUG options helpers

  PR:		241361
  Submitted by:	tobik@
  MFH:		2019Q4 (blanket, adds an option that defaults to off)

Changes:
  head/databases/db5/Makefile
  head/databases/db6/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-10-21 18:23:22 UTC
A commit references this bug:

Author: mandree
Date: Mon Oct 21 18:23:11 UTC 2019
New revision: 515118
URL: https://svnweb.freebsd.org/changeset/ports/515118

Log:
  MFH: r515117

  databases/db5, databases/db6: Hook up DEBUG options helpers

  PR:		241361
  Submitted by:	tobik@

  Approved by:	ports-secteam (blanket, adds an OPTION that defaults to off)

Changes:
_U  branches/2019Q4/
  branches/2019Q4/databases/db5/Makefile
  branches/2019Q4/databases/db6/Makefile