Bug 241382

Summary: net/samba48, net/samba410 make LibZFS optional for real
Product: Ports & Packages Reporter: lytboris
Component: Individual Port(s)Assignee: Timur I. Bakeyev <timur>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: lytboris
Priority: --- Flags: bugzilla: maintainer-feedback? (timur)
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
Initial version none

Description lytboris 2019-10-20 21:53:12 UTC
Created attachment 208471 [details]
Initial version

Even though LibZFS has knob in OPTIONS, it is expected to build every time as per pkg-plist.

Patch proposed makes it optional for real.
Comment 1 lytboris 2019-10-20 22:00:51 UTC
Patch is incomplete, will post a new PR once tested properly.
Comment 2 Timur I. Bakeyev freebsd_committer 2019-10-21 00:01:57 UTC
I think you are confused what ZFS ACL VFS module is doing
Comment 3 lytboris 2019-10-24 20:29:40 UTC
Yeah, most probably.

Is there any reason to keep LIBZFS option semi-implemented in Makefile?
Comment 4 Timur I. Bakeyev freebsd_committer 2019-10-25 07:30:53 UTC
(In reply to lytboris from comment #3)

This is remain of the times I was trying to merge iXsystems Samba port and the FreeBSD one.

This still has to be implemented, as it provides additional value, but first libZFS has to be reliably build from the existing source code/ports tree.

So far I couldn't find reliable solution for this...