Bug 241427

Summary: cad/openvsp: fix build on arm*
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape
Priority: --- Flags: fernape: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (fernape)

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-10-23 07:50:05 UTC 
Created attachment 208522 [details]
patch

-mimplicit-it=always breaks build on arm*. Remove it to fix build.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2019-10-23 16:45:09 UTC 
Hi Piotr,

Thanks for the patch. As with bug #241325, I can not test it on ARM, but will test the patch in other versions/archs and come back to you with feedback.

Cheers.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2019-10-24 21:14:32 UTC 
LGTM.

Builds where it built before and runs fine in 12.0 amd64.

Feel free to commit this on my behalf once you get mentors approval.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2019-10-25 03:10:09 UTC 
Approved as mentor.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-10-27 19:22:15 UTC 
A commit references this bug:

Author: pkubaj
Date: Sun Oct 27 19:21:13 UTC 2019
New revision: 515816
URL: https://svnweb.freebsd.org/changeset/ports/515816

Log:
  cad/openvsp: fix build on arm*

  -mimplicit-it=always breaks build on arm*. Remove it to fix build.

  PR:		241427
  Reviewed by:	fernape (maintainer), linimon (mentor)

Changes:
  head/cad/openvsp/Makefile
  head/cad/openvsp/files/patch-src_external_angelscript_sdk_CMakeLists.txt