Summary: | diff: --tabsize dies with SIGSEGV | ||
---|---|---|---|
Product: | Base System | Reporter: | rlwestlund |
Component: | bin | Assignee: | Kubilay Kocak <koobs> |
Status: | Closed DUPLICATE | ||
Severity: | Affects Some People | CC: | fnoyanisi, pprocacci, rlwestlund |
Priority: | --- | Keywords: | crash |
Version: | 12.1-RELEASE | ||
Hardware: | Any | ||
OS: | Any |
Description
rlwestlund
2019-11-05 00:23:06 UTC
I'm trying to attach the core dump, but the server is telling me 413 Request Entity Too Large. What should I do about this? I assume the core dump is important. Sorry to post again, but the uname -a output I posted in the first comment was wrong. It says: FreeBSD coppermind 12.1-RELEASE FreeBSD 12.1-RELEASE r354233 GENERIC amd64 The 12.0-RELEASE-p10 output I posted was copy-pasted from having the issue on 12.0-RELEASE-p10 first, which was what prompted me to upgrade to 12.1-RELEASE to see if that fixed it. (I had saved the draft of my post from before then in a text file to reboot, and pasted it back in, and forgot to edit that part). tabsize is set to have an optional argument. I can't explain why as it seems to me it always require an argument. This patch here makes tabsize require an argument which also solves the problem of the SEGfault as line 255 of diff.c is expecting optarg to be something. --- diff.c.orig 2019-11-20 01:16:41.377456000 -0500 +++ diff.c 2019-11-20 01:16:51.176400000 -0500 @@ -90,7 +90,7 @@ { "no-ignore-file-name-case", no_argument, NULL, OPT_NO_IGN_FN_CASE }, { "normal", no_argument, NULL, OPT_NORMAL }, { "strip-trailing-cr", no_argument, NULL, OPT_STRIPCR }, - { "tabsize", optional_argument, NULL, OPT_TSIZE }, + { "tabsize", required_argument, NULL, OPT_TSIZE }, { "changed-group-format", required_argument, NULL, OPT_CHANGED_GROUP_FORMAT}, { NULL, 0, 0, '\0'} }; Oh, that explains it. I thought it crashed even if I passed it an option because I was trying to pass it with a space. You're right, with --tabisze=3 it doesn't crash. I created a bug report for the same issue and I am keen to update the argument to --tabsize as required since it does not make much sense to use --tabsize without an argument to set the number of space characters required for a single tab. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243974 ^Triage: It's normally preferable to close later issue ID's as duplicates of the original (older) ones. In this case, the newer bug has already been referenced by commits, so close this as a duplicate of bug 243974 *** This bug has been marked as a duplicate of bug 243974 *** |