Bug 241785
| Summary: | ix(4): Creating vlan over lagg causes flapping with Intel drivers and iflib | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Konrad <konrad.kreciwilk> |
| Component: | kern | Assignee: | Eric Joyner <erj> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | afedorov, backdoor, emaste, net, nonesuch, rudolphfroger |
| Priority: | --- | Flags: | erj:
mfc-stable12+
koobs: mfc-stable11- |
| Version: | 12.1-RELEASE | ||
| Hardware: | amd64 | ||
| OS: | Any | ||
| URL: | https://reviews.freebsd.org/D24659 | ||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240818 | ||
|
Description
Konrad
2019-11-07 17:40:50 UTC
This is a known issue with iflib + intel drivers: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240818 https://lists.freebsd.org/pipermail/freebsd-net/2018-November/052184.html We also use vlan + lagg + ix and we often need to add/remove vlans, so as a temporary solution we disable vlanhwfilter on lagg interface. Need help testing this patch: https://reviews.freebsd.org/D24659 A commit references this bug: Author: erj Date: Mon May 11 17:42:06 UTC 2020 New revision: 360902 URL: https://svnweb.freebsd.org/changeset/base/360902 Log: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method Pursuant to r360398, implement driver-specific versions of the ifdi_needs_restart iflib device method. Some (if not most?) Intel network cards don't need reinitializing when a VLAN is added or removed from the device hardware, so these implement ifdi_needs_restart in a way that tell iflib not to bring the interface up or down when a VLAN is added or removed, regardless of whether the VLAN_HWFILTER interface capability flag is set or not. This could potentially solve several PRs relating to link flaps that occur when VLANs are added/removed to devices. Signed-off-by: Eric Joyner <erj@freebsd.org> PR: 240818, 241785 Reviewed by: gallatin@, olivier@ MFC after: 3 days MFC with: r360398 Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D24659 Changes: head/sys/dev/e1000/if_em.c head/sys/dev/ixgbe/if_ix.c head/sys/dev/ixgbe/if_ixv.c head/sys/dev/ixl/if_iavf.c head/sys/dev/ixl/if_ixl.c A commit references this bug: Author: erj Date: Thu May 14 19:56:56 UTC 2020 New revision: 361053 URL: https://svnweb.freebsd.org/changeset/base/361053 Log: MFC r360398 and r360902 These commits introduce a new iflib device-dependent method and implements that method in the Intel ethernet network drivers; this method tells iflib if the network interface needs to be restarted when certain events happen. This fixes several issues that occur when VLANs are registered or unregistered with the network interface. PR: 240818, 241785 Sponsored by: Intel Corporation Changes: _U stable/12/ stable/12/sys/dev/e1000/if_em.c stable/12/sys/dev/ixgbe/if_ix.c stable/12/sys/dev/ixgbe/if_ixv.c stable/12/sys/dev/ixl/if_iavf.c stable/12/sys/dev/ixl/if_ixl.c stable/12/sys/net/ifdi_if.m stable/12/sys/net/iflib.c stable/12/sys/net/iflib.h ^Triage: - Assign to committer resolving - Assume stable/11 isn't getting an MFC given only stable/12 has iflib. If this is not the case, set mfc-stable11 to ? and set to + when merged I have a follow up to this issue. I am seeing this problem on non-intel non-iflib cards as well , on 12.1-STABLE . In my case I have solarflare cards setup with a LACP lagg with vlans on top. I am sporadically seeing the lagg members flap for reasons I can not establish. Could this be related ? (In reply to nonesuch from comment #6) I'd want to say that if it's non-Intel and/or non-iflib, then the problem isn't the same as this one. It's possible there's a similar problem that's contained in the Solarflare driver, though, but I have never looked at that driver. i noticed this too on 12.1 is this a related issue the bug ? lagg0: link state changed to DOWN lagg0: link state changed to UP em3: Interface stopped DISTRIBUTING, possible flapping em2: Interface stopped DISTRIBUTING, possible flapping lagg0: link state changed to DOWN lagg0: link state changed to UP em3: Interface stopped DISTRIBUTING, possible flapping em2: Interface stopped DISTRIBUTING, possible flapping lagg0: link state changed to DOWN lagg0: link state changed to UP em3: Interface stopped DISTRIBUTING, possible flapping em2: Interface stopped DISTRIBUTING, possible flapping lagg0: link state changed to DOWN lagg0: link state changed to UP em3: Interface stopped DISTRIBUTING, possible flapping em2: Interface stopped DISTRIBUTING, possible flapping lagg0: link state changed to DOWN lagg0: link state changed to UP when i switch from LACP to fail over the possible flapping error disappear. ^Triage: the 12 branch is now out of support. Apparently committed back in 2020. |
