Bug 241823

Summary: deskutils/nextcloudclient: Rewriting keyring file every few seconds
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Michael Reifenberger <mr>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: needs-patch
Priority: --- Flags: bugzilla: maintainer-feedback? (mr)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D22620
See Also: https://github.com/nextcloud/desktop/issues/1592
Attachments:
Description Flags
workaround none

Description Guido Falsi freebsd_committer 2019-11-09 13:55:31 UTC
Hi,

I'm creating this bug report to link here a bug report I filed upstream and track progress.

the nextcloud desktop client is performing writes to the keyring file very few seconds. Every time it contacts the server to check for changes.

It looks like this is a regression introduced in version 2.6.1.

I have isolated the upstream commit introducing this and a single code line that can be commented out to stop this behaviour. The details are in the github issue here:

https://github.com/nextcloud/desktop/issues/1592

but simply commenting out that line is not a proper solution.
Comment 1 Guido Falsi freebsd_committer 2019-11-15 15:31:23 UTC
Created attachment 209166 [details]
workaround

I'm attaching a very simple patch I'm using as a workaround.

This patch makes the unwanted writes to the key ring stop.

It most probably has collateral effects on the remote wipe functionlaity.
Comment 2 Guido Falsi freebsd_committer 2019-12-01 14:04:49 UTC
Comment on attachment 209166 [details]
workaround

Upstream provided a fix for this. [1]

I created a code review on phabricator to import it.


[1] https://github.com/nextcloud/desktop/commit/dcc84d35085d790a53b472d1edba663832af238a
Comment 3 commit-hook freebsd_committer 2019-12-01 15:48:00 UTC
A commit references this bug:

Author: mr
Date: Sun Dec  1 15:47:02 UTC 2019
New revision: 518779
URL: https://svnweb.freebsd.org/changeset/ports/518779

Log:
  Add patch to fix problem with keyring rewriting.

  PR:		241823
  Submitted by:	Guido Falsi

Changes:
  head/deskutils/nextcloudclient/Makefile
  head/deskutils/nextcloudclient/files/patch-fix_remote_wipe_keychain_storage
Comment 4 Guido Falsi freebsd_committer 2019-12-01 17:12:39 UTC
Thanks!