Bug 241874
| Summary: | textproc/py-elasticsearch6: Prepare for urllib3 >= 1.25 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kai Knoblich <kai> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | kai, sunpoet | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) kai: merge-quarterly? |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/elastic/elasticsearch-py/commit/4c531c5cdbd5ba8b59be16c2fa15d5cf81d0a92f | ||||||
| See Also: | https://github.com/elastic/elasticsearch-py/pull/987 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 229322 | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: sunpoet Date: Wed Nov 13 23:47:49 UTC 2019 New revision: 517541 URL: https://svnweb.freebsd.org/changeset/ports/517541 Log: Fix build with py-urllib 1.25+ - Bump PORTREVISION for package change PR: 241874 Submitted by: kai Backport from: https://github.com/elastic/elasticsearch-py/commit/4c531c5cdbd5ba8b59be16c2fa15d5cf81d0a92f Changes: head/textproc/py-elasticsearch6/Makefile head/textproc/py-elasticsearch6/files/ head/textproc/py-elasticsearch6/files/patch-elasticsearch-connection-http_urllib3.py Committed. Thanks! (In reply to Sunpoet Po-Chuan Hsieh from comment #2) Hi Sunpoet, thanks for committing the patch. Can you please also merge it to the 2019Q4 branch? I've re-opened the issue as the MFH is still pending and once merged it will pave the way for urllib 1.25 for the 2019Q4 branch a bit more. (In reply to Kai Knoblich from comment #3) Then I need an approval from either portmgr or ports-secteam. (In reply to Sunpoet Po-Chuan Hsieh from comment #4) Yes, indeed. Can you please still get the approval in the next few days? If not, I'll try to get the approval for it to the next weekend and do the MFH then. A commit references this bug: Author: sunpoet Date: Mon Nov 25 09:28:59 UTC 2019 New revision: 518389 URL: https://svnweb.freebsd.org/changeset/ports/518389 Log: MFH: r517541 Fix build with py-urllib 1.25+ - Bump PORTREVISION for package change PR: 241874 Submitted by: kai Backport from: https://github.com/elastic/elasticsearch-py/commit/4c531c5cdbd5ba8b59be16c2fa15d5cf81d0a92f Approved by: ports-secteam (joneum) Changes: _U branches/2019Q4/ branches/2019Q4/textproc/py-elasticsearch6/Makefile branches/2019Q4/textproc/py-elasticsearch6/files/ (In reply to Kai Knoblich from comment #5) MFH'd. Thanks! |
Created attachment 209049 [details] py-elasticsearch-prepare-for-urllib3-1.25.patch Hi Sunpoet, attached is a patch that fixes the "verify_certs=False" behavior for net/py-urllib >= 1.25 because that version has SSL certificate verification enabled by default. The patch for "elasticsearch/connection/http_urllib3.py" was fixed by upstream in release 7.0.5 and was backported from there. This change needs also to be MFH'ed because the 1.25.x release of net/py-urllib3 is going to be merged into the 2019Q4 branch. QA: ~~~ - poudriere (11.3-RELEASE amd64) for each py27 + py36 flavor -> OK