Bug 241904

Summary: [PATCH] Mk/Uses/php.mk: Stale PHP_VERSION variable prevent to use dependency on mod_php and cgi/fpm/embed checks
Product: Ports & Packages Reporter: Dima Panov <fluffy>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed Not A Bug    
Severity: Affects Many People    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
PHP_VERSION -> PHP_VER check none

Description Dima Panov freebsd_committer freebsd_triage 2019-11-12 04:52:16 UTC 
Created attachment 209084 [details]
PHP_VERSION -> PHP_VER check

Mk/Uses/php.mk: Stale PHP_VERSION variable prevent to use dependency on mod_php and cgi/fpm/embed checks

AFIU, PHP_VERSION should be replaced by PHP_VER by logic
Comment 1 Alex Dupre freebsd_committer freebsd_triage 2019-11-12 06:46:24 UTC 
Nope, PHP_VERSION is set only when PHP is already installed, and those checks have to be performed only in that case, otherwise you can always install the correct dependencies.
Comment 2 Dima Panov freebsd_committer freebsd_triage 2019-11-12 08:03:10 UTC 
(In reply to Alex Dupre from comment #1)

In clean environment (poudriere) these checks was always skipped, and no dependency on mod_php/apache registered at all while php:mod or php:web was requested:(
Comment 3 Dima Panov freebsd_committer freebsd_triage 2019-11-12 08:09:31 UTC 
Oh, I see it. Depend on apache only if it exist in environment. Ok. Sorry for misunderstood