Summary: | [PATCH] databases/tdb does not respect DEBUG option | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | ml | ||||
Component: | Individual Port(s) | Assignee: | Timur I. Bakeyev <timur> | ||||
Status: | Closed Overcome By Events | ||||||
Severity: | Affects Only Me | CC: | diizzy | ||||
Priority: | --- | Keywords: | buildisok, patch | ||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(timur) |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/99097176 I'm wondering, if: DEBUG_VARS= WITH_DEBUG=yes would also fix this issue? As STRIP should be redefined to `true` in this case. I tried compiling "WITH_DEBUG=yes" and deployed it to a few servers (AD DCs and AD members). On all of them this started producing tons of secrets.ldb.trace.[0-9]*, sam.ldb.trace.[0-9]*, schannel_store.tdb.trace.[0-9]*, etc... in /var/db/samba4/private. Monitoring advised that that partition was getting full and saved me. Rebuilding without "WITH_DEBUG=yes" reverted everything to normal. Now we might discuss what the DEBUG option should do: I thought it just meant compiling with debug info and not stripping. If it's so, then this change is wrong. OTOH if this *should* produce that result, then it's ok: # file /usr/local/bin/tdbbackup /usr/local/bin/tdbbackup: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 11.3, FreeBSD-style, with debug_info, not stripped Still broken using the current version in tree? (In reply to Daniel Engberg from comment #4) Look like it's OK to me. Putting "WITH_DEBUG_PORTS+=databases/tdb" in /usr/local/etc/poudriere.d/make.conf, makes the binaries not stripped (with or without the DEBUG option). So I think we can close the bug. Some more info on DEBUG option, though, would be useful IMHO. Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi> |
Created attachment 209126 [details] SVN patch that corrects Makefile Binaries are stripped anyway.