Bug 242079

Summary: games/jumpnbump: fix build on GCC architectures and with threaded builds
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: amdmi3, linimon
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
v2 pkubaj: maintainer-approval? (amdmi3)

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-11-19 13:33:00 UTC
Created attachment 209252 [details]
patch

Without USES=compiler:c11:
gfx.c:667: error: expected declaration specifiers or '...' before 'gob_t'
gfx.c:668: warning: conflicting types for 'put_pob'
gfx.c:661: warning: previous implicit declaration of 'put_pob' was here
gfx.c: In function 'put_pob':
gfx.c:679: error: 'gob' undeclared (first use in this function)

Without MAKE_JOBS_UNSAFE=yes:
/usr/local/bin/ld: jnbunpack.o: file not recognized: file truncated                                       collect2: error: ld returned 1 exit status
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2019-11-19 13:33:55 UTC
Created attachment 209253 [details]
v2

Actually add MAKE_JOBS_UNSAFE=yes.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-11-21 21:10:45 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Nov 21 21:10:39 UTC 2019
New revision: 518113
URL: https://svnweb.freebsd.org/changeset/ports/518113

Log:
  - Fix build on gcc archs by requiring newer compiler

  PR:		242079
  Submitted by:	pkubaj@FreeBSD.org

Changes:
  head/games/jumpnbump/Makefile
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2019-11-21 21:11:26 UTC
USES=compiler:c11 committed, MAKE_JOBS_UNSAFE should not be needed after the update, as the build is no longer parallel.