Bug 242089

Summary: devel/upnp: Update to 1.10.0
Product: Ports & Packages Reporter: Lorenzo Salvadore <salvadore>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: buildisok
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/mrjimenez/pupnp/blob/release-1.10.0/ChangeLog
Attachments:
Description Flags
upnp - 1.10.0 salvadore: maintainer-approval+

Description Lorenzo Salvadore freebsd_committer freebsd_triage 2019-11-19 23:19:05 UTC 
Created attachment 209260 [details]
upnp - 1.10.0

Update to 1.10.0.
Changelog: https://github.com/mrjimenez/pupnp/blob/release-1.10.0/ChangeLog

Tested successfully with poudriere on {11.3,12.1}-RELEASE {i386,amd64}.

The following ports optionally depend on devel/upnp:
multimedia/vlc
net-p2p/amule
net-p2p/amule-dev

They have all been tested successfully with the proposed patch and the UPNP option enabled through poudriere on {11.3,12.1}-RELEASE {i386,amd64}.
They do not require PORTREVISION bumps as the UPNP option is disabled by default for all of them.
Comment 1 Automation User 2019-11-19 23:42:39 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/97121927
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-11-20 06:04:48 UTC 
(In reply to Lorenzo Salvadore from comment #0)
> They do not require PORTREVISION bumps as the UPNP option is disabled by default for all of them.

No, this reasoning is wrong.  PORTREVISION must be bumped even for
non-default options.  You do not know who has enabled the UPNP
option in these ports and would get into trouble if we do not do
it.  Also see the Porter's Handbook [1]:

"PORTREVISION must be increased each time a change is made to the
port that changes the generated package in any way.  That includes
changes that only affect a package built with non-default options."

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#makefile-portrevision
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-11-20 06:46:59 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-11-20 06:47:41 UTC 
A commit references this bug:

Author: tobik
Date: Wed Nov 20 06:46:41 UTC 2019
New revision: 517993
URL: https://svnweb.freebsd.org/changeset/ports/517993

Log:
  devel/upnp: Update to 1.10.0

  Bump consumers for ABI changes.

  Changes:	https://github.com/mrjimenez/pupnp/blob/release-1.10.0/ChangeLog
  PR:		242089
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch> (maintainer)

Changes:
  head/devel/upnp/Makefile
  head/devel/upnp/distinfo
  head/devel/upnp/pkg-plist
  head/multimedia/vlc/Makefile
  head/net-p2p/amule/Makefile
  head/net-p2p/amule-devel/Makefile