Bug 242128

Summary: Add ID for Diamond Multimedia BVU195 Display Link device
Product: Base System Reporter: Daniel O'Connor <darius>
Component: usbAssignee: Hans Petter Selasky <hselasky>
Status: Closed FIXED    
Severity: Affects Some People CC: hselasky
Priority: --- Keywords: patch
Version: 12.0-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Daniel O'Connor 2019-11-21 04:17:06 UTC
Created attachment 209308 [details]
patch

With this diff I can run X etc..
I only tested it at 1280x1024 but it seemed fine - the chip type is a guess though, I am not sure how to find out what it is.

I disassembled the device but the heatsink is glued on to it so it's hard to find out.
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2019-11-21 07:32:50 UTC
Patch looks good.

Do you have the output from usbconfig ?

--HPS
Comment 2 Daniel O'Connor 2019-11-21 07:43:49 UTC
Like this?

[maarsy-acq3 7:38] ~> usbconfig -d 0.7 dump_all_desc
ugen0.7: <DisplayLink USB to DVI-19> at usbus0, cfg=0 md=HOST spd=HIGH (480Mbps) pwr=ON (500mA)

  bLength = 0x0012
  bDescriptorType = 0x0001
  bcdUSB = 0x0200
  bDeviceClass = 0x0000  <Probed by interface class>
  bDeviceSubClass = 0x0000
  bDeviceProtocol = 0x0000
  bMaxPacketSize0 = 0x0040
  idVendor = 0x17e9
  idProduct = 0x0360
  bcdDevice = 0x0112
  iManufacturer = 0x0001  <DisplayLink>
  iProduct = 0x0002  <USB to DVI-19>
  iSerialNumber = 0x0003  <169725>
  bNumConfigurations = 0x0001

 Configuration index 0

    bLength = 0x0009
    bDescriptorType = 0x0002
    wTotalLength = 0x0049
    bNumInterfaces = 0x0001
    bConfigurationValue = 0x0001
    iConfiguration = 0x0000  <no string>
    bmAttributes = 0x0080
    bMaxPower = 0x00fa

    Interface 0
      bLength = 0x0009
      bDescriptorType = 0x0004
      bInterfaceNumber = 0x0000
      bAlternateSetting = 0x0000
      bNumEndpoints = 0x0003
      bInterfaceClass = 0x00ff  <Vendor specific>
      bInterfaceSubClass = 0x0000
      bInterfaceProtocol = 0x0000
      iInterface = 0x0000  <no string>

      Additional Descriptor

      bLength = 0x22
      bDescriptorType = 0x5f
      bDescriptorSubType = 0x01
       RAW dump:
       0x00 | 0x22, 0x5f, 0x01, 0x00, 0x20, 0x05, 0x00, 0x01,
       0x08 | 0x03, 0x00, 0x04, 0x04, 0x01, 0x00, 0x03, 0xc0,
       0x10 | 0x00, 0x02, 0x04, 0xc0, 0x02, 0x24, 0x00, 0x01,
       0x18 | 0x04, 0x01, 0x02, 0x01, 0x02, 0x04, 0x00, 0x08,
       0x20 | 0x00, 0x00


     Endpoint 0
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x0001  <OUT>
        bmAttributes = 0x0002  <BULK>
        wMaxPacketSize = 0x0200
        bInterval = 0x0000
        bRefresh = 0x0000
        bSynchAddress = 0x0000

     Endpoint 1
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x0082  <IN>
        bmAttributes = 0x0003  <INTERRUPT>
        wMaxPacketSize = 0x0008
        bInterval = 0x0004
        bRefresh = 0x0000
        bSynchAddress = 0x0000

     Endpoint 2
        bLength = 0x0007
        bDescriptorType = 0x0005
        bEndpointAddress = 0x000a  <OUT>
        bmAttributes = 0x0002  <BULK>
        wMaxPacketSize = 0x0200
        bInterval = 0x0000
        bRefresh = 0x0000
        bSynchAddress = 0x0000
Comment 3 Hans Petter Selasky freebsd_committer freebsd_triage 2019-11-21 16:37:07 UTC
I also need the chunk for sys/dev/usb/usbdevs .
Comment 4 Hans Petter Selasky freebsd_committer freebsd_triage 2019-11-21 16:41:35 UTC
Nevermind.
Comment 5 Hans Petter Selasky freebsd_committer freebsd_triage 2019-11-21 16:43:06 UTC
Thank you for supporting FreeBSD.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-11-21 16:43:25 UTC
A commit references this bug:

Author: hselasky
Date: Thu Nov 21 16:42:25 UTC 2019
New revision: 354969
URL: https://svnweb.freebsd.org/changeset/base/354969

Log:
  Add USB ID for Diamond Multimedia BVU195 Display Link device.

  Submitted by:	darius@dons.net.au
  PR:		242128
  MFC after:	1 week
  Sponsored by:	Mellanox Technologies

Changes:
  head/sys/dev/usb/usbdevs
  head/sys/dev/usb/video/udl.c
Comment 7 Daniel O'Connor 2019-11-21 21:14:17 UTC
Thanks!
Sorry about the diff, I accidentally used > instead of >> when making it.
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-12-10 07:06:44 UTC
A commit references this bug:

Author: hselasky
Date: Tue Dec 10 07:06:33 UTC 2019
New revision: 355577
URL: https://svnweb.freebsd.org/changeset/base/355577

Log:
  MFC r354969:
  Add USB ID for Diamond Multimedia BVU195 Display Link device.

  Submitted by:	darius@dons.net.au
  PR:		242128
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/sys/dev/usb/usbdevs
  stable/12/sys/dev/usb/video/udl.c
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-12-10 07:07:46 UTC
A commit references this bug:

Author: hselasky
Date: Tue Dec 10 07:07:18 UTC 2019
New revision: 355578
URL: https://svnweb.freebsd.org/changeset/base/355578

Log:
  MFC r354969:
  Add USB ID for Diamond Multimedia BVU195 Display Link device.

  Submitted by:	darius@dons.net.au
  PR:		242128
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/11/
  stable/11/sys/dev/usb/usbdevs
  stable/11/sys/dev/usb/video/udl.c