Bug 242133

Summary: handbook/firewalls fix for removing hosts from the block list
Product: Documentation Reporter: Mikael Urankar <mikael>
Component: Books & ArticlesAssignee: Benedict Reuschling <bcr>
Status: Closed FIXED    
Severity: Affects Only Me CC: bcr
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Mikael Urankar freebsd_committer freebsd_triage 2019-11-21 08:14:31 UTC
Created attachment 209313 [details]
patch

Running the example from the book results in an error:

pfctl -a blacklistd/22 -T delete 213.0.123.128/25
usage: pfctl [-AdeghmNnOPqRrvz] [-a anchor] [-D macro=value] [-F modifier]
        [-f file] [-i interface] [-K host | network]
        [-k host | network | label | id] [-o level] [-p device]
        [-s modifier] [-t table -T command [address ...]] [-x level]

it should be:
pfctl -a blacklistd/22 -t port22 -T delete 213.0.123.128/25
0/1 addresses deleted.

tested on 11.3 and 13-current.
Comment 1 Benedict Reuschling freebsd_committer freebsd_triage 2019-11-21 08:31:02 UTC
Take this one, I wrote the article and will check to make sure the instructions are correct.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-12-31 13:26:10 UTC
A commit references this bug:

Author: bcr
Date: Tue Dec 31 13:25:56 UTC 2019
New revision: 53723
URL: https://svnweb.freebsd.org/changeset/doc/53723

Log:
  Add the missing -t <table> parameter to the
  delete example. Without it, there will be an
  error message shown and the address will not
  be deleted.

  PR:		242133
  Submitted by:	mikael.urankar@gmail.com

Changes:
  head/en_US.ISO8859-1/books/handbook/firewalls/chapter.xml
Comment 3 Benedict Reuschling freebsd_committer freebsd_triage 2019-12-31 13:27:25 UTC
I've committed your change. Thanks for letting us know about it. 
PR closed!