Bug 242141

Summary: games/scid: fix build on arm and powerpc
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Piotr Kubaj <pkubaj>
Status: Closed FIXED    
Severity: Affects Only Me CC: bsd, linimon
Priority: --- Flags: bsd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (bsd)

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-11-21 14:43:26 UTC
Created attachment 209319 [details]
patch

Explicitly set signed char for variables that are negative to prevent signed/unsigned issue on arm and powerpc.
Comment 1 Friedrich Volkmann 2019-11-21 22:57:47 UTC
This change cannot be wrong, and I think it should be contributed to the scid project as well.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-12-06 12:55:55 UTC
A commit references this bug:

Author: pkubaj
Date: Fri Dec  6 12:55:23 UTC 2019
New revision: 519137
URL: https://svnweb.freebsd.org/changeset/ports/519137

Log:
  games/scid: fix build on arm and powerpc

  Explicitly set signed char for variables that are negative to prevent signed/unsigned issue on arm and powerpc.

  PR:		242141
  Approved by:	bsd@volki.at (maintainer), linimon (mentor)
  Differential Revision:	https://reviews.freebsd.org/D22581

Changes:
  head/games/scid/files/patch-src_fastgame.h