Bug 242142

Summary:	x11-fm/thunar does not merge folders anymore
Product:	Ports & Packages	Reporter:	Marko Cupać <marko.cupac>
Component:	Individual Port(s)	Assignee:	freebsd-xfce (Nobody) <xfce>
Status:	Closed Works As Intended
Severity:	Affects Only Me	CC:	madpilot
Priority:	---	Flags:	madpilot: maintainer-feedback+
Version:	Latest
Hardware:	amd64
OS:	Any
See Also:	https://bugzilla.xfce.org/show_bug.cgi?id=13291

Description Marko Cupać 2019-11-21 15:01:22 UTC

Hi,

since thunar-1.8.11, folders of same name are not merged anymore, prompt to overwrite / skip / cancel is shown instead.

Example:

I have the following:

/home/user/folderA/fileA.txt

/home/user/test/folderA/fileB.txt

Before, I could drag'n'drop' /home/user/test/folderA to /home/user/, and it would result in merging of two folders - /home/user/folderA/ would contain two files - fileA.txt and fileB.txt.

Now, I am being asked if I want to overwrite contents of /home/user/folderA with contents od /home/user/test/folderA

Couldn't find anything FreeBSD-specific, but there's thread on ArchLinux forum:
https://bbs.archlinux.org/viewtopic.php?id=250806

Any chance to have this fixed?

Comment 1 Guido Falsi freebsd_committer

2019-11-21 15:55:45 UTC

I tested on a manjaro linux VM and got the same behaviour, I also have 1.8.10 there, so it's not FreeBSD specific.

It would be useful to narrow down when this started to happen. It could also be an intentional change, I suspect this changed between version 1.6.x and 1.8.x

Looking at the commit history I don't see anything which clearly could have changed this. I don't know the thunar code enough to change this.

I have found two bug reports in their bugzilla considering the behaviour you ask for as the broken one:

https://bugzilla.xfce.org/show_bug.cgi?id=13291
https://bugzilla.xfce.org/show_bug.cgi?id=9847

I think this needs to be discussed upstream in a bug report there.

Can you open one or followup to one of the two above if you deem that appropriate?

Comment 2 Guido Falsi freebsd_committer

2019-11-21 16:01:19 UTC

(In reply to Guido Falsi from comment #1)

Sorry, upstream https://bugzilla.xfce.org/show_bug.cgi?id=9847 is unrelated.

Anyway https://bugzilla.xfce.org/show_bug.cgi?id=9847 looks quite correct, We should inquire there when exactly the change happened and what is the rationale.

Comment 3 Guido Falsi freebsd_committer

2019-11-21 16:15:45 UTC

I performed another test.

If at the requester asking to replace the directory i tell it to replace it, it actually merges it.

At least that's what it did here.

Comment 4 Marko Cupać 2019-11-22 09:32:18 UTC

(In reply to Guido Falsi from comment #3)

Indeed, as you say, folders eventually get merged after clicking "Replace", which means I haven't lost functionality I like.

Still, this is quite misleading, as folder isn't getting replaced. I'm not native English speaker, but I understand "to replace" as "to put something in place of something that was there before".

If old behaviour of silently merging is going to be abandoned, I think new way should be configurable by user, and options should be "Merge", "Replace/Overwrite" and "Cancel".

Regards,

Comment 5 Guido Falsi freebsd_committer

2019-11-22 09:40:23 UTC

I fundamentally agree with you.

There is no real indication the functionality is going away or being changed though.

Anyway your concerns should be expressed to the thunar developers, since I'm simply keeping our ports updated, and ports can, in general, only reflect what the upstream project does.

You should really followup to the linked upstream bug report and express your concerns there, and in any other upstream relevant bug report (if there are any others).

Are you ok if I close this bug as "works as intended" and the discussion is moved upstream?

Comment 6 Marko Cupać 2019-11-22 10:44:12 UTC

(In reply to Guido Falsi from comment #5)

Sure, feel free to close it, this is definitely not FreeBSD port issue, but upstream issue.

I'll follow up on https://bugzilla.xfce.org/show_bug.cgi?id=13291

Regards,