Bug 242202
| Summary: | emulators/wine-devel: fails to build 4.20 | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> |
| Component: | Individual Port(s) | Assignee: | Gerald Pfeifer <gerald> |
| Status: | Closed Unable to Reproduce | ||
| Severity: | Affects Only Me | ||
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Vladimir Druzenko
2019-11-24 19:21:45 UTC
(In reply to VVD from comment #0) > OPTIONS_FILE_UNSET+=GCC I have not received any notification from the any of the autobuilders or other users about such a breakage. Did this work for you with Wine 4.19 and only broke with Wine 4.20? And can you please retry with the GCC options set (which is the default)? I would be totally not surprised if it worked when built with GCC - and maybe we ought to make GCC mandatory? (In reply to Gerald Pfeifer from comment #1) > Did this work for you with Wine 4.19 and only broke with Wine 4.20? Yes, ofc. Build fine all 4.x and 3.x versions. > And can you please retry with the GCC options set (which is the default)? Build fine with OPTIONS_FILE_SET+=GCC on both i386 and amd64. (In reply to VVD from comment #2) > Build fine all 4.x and 3.x versions. But it was 12.0 with clang 6, not 12.1 with clang 8. Sorry, I could not reproduce this and have not received any other reports in that direction, neither from our build bots not from users. I have, however, updated the emulators/wine-devel port twice in terms of version and some beyond, and plan on another version update in the next days. Hopefully one of those has addressed this (or will) - or it's been really specific to your environment, I a recommend a fresh build/install of all relevant ports, to be on the safe side. Oh, wait a minute: You are saying you disabled the GCC option (which is the default), and then it failed with clang? Please don't do that unless you are willing and able to address any issues found that way by contributing upstream and working with upstream at https://winehq.org. (In reply to Gerald Pfeifer from comment #5) > You are saying you disabled the GCC option (which is the default), and then it failed with clang? Yes. It isn't obvious that: > Please don't do that unless you are willing and able to address any issues found that way by contributing upstream and working with upstream at https://winehq.org. Add description to option GCC… (In reply to VVD from comment #6) > It isn't obvious that: > "Please don't do that unless you are willing and able to address > any issues found that way by contributing upstream and working with > upstream at https://winehq.org." > > Add description to option GCC… Having received another report just recently, reminded me of this and I will remove the GCC option from emulators/wine at least (i.e., enforce GCC instead of having it as the default). This also will simplify the case we'll likely add in a bit to enable compilation with MinGW. I considered adding a port-specific variant of the description for the GCC option, alas it's a bit tricky to well explain in the space available (since this is not a feature when GCC is on, rather when it's off). Do you have a good recommendation? (In reply to Gerald Pfeifer from comment #7) Sorry, but I didn't understand you… My english is too poor… A commit references this bug: Author: gerald Date: Tue Jan 5 14:26:14 UTC 2021 New revision: 560399 URL: https://svnweb.freebsd.org/changeset/ports/560399 Log: Remove the GCC option. which has been the default all along, and simply use GCC. This avoids troubles for users disabling the option and then encountering failures without knowing how to go about that. (And there is not much one can even do given upstream focuses on GCC.) PR: 242202 Changes: head/emulators/wine/Makefile A commit references this bug: Author: gerald Date: Thu Jan 14 22:58:34 UTC 2021 New revision: 561610 URL: https://svnweb.freebsd.org/changeset/ports/561610 Log: Forward port r560399 | gerald | 2021-01-05 from emulators/wine: Remove the GCC option. which has been the default all along, and simply use GCC. This avoids troubles for users disabling the option and then encountering failures without knowing how to go about that. (And there is not much one can even do given upstream focuses on GCC.) PR: 242202 Changes: head/emulators/wine-devel/Makefile |