Bug 242254 (cmake-3.16.0)

Summary: [exp-run] Upgrade cmake to 3.16.0
Product: Ports & Packages Reporter: Tobias C. Berner <tcberner>
Component: Individual Port(s)Assignee: Adriaan de Groot <adridg>
Status: Closed FIXED    
Severity: Affects Only Me CC: adridg, grarpamp, kde
Priority: --- Flags: antoine: exp-run+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1
none
v2
none
v3 none

Description Tobias C. Berner freebsd_committer freebsd_triage 2019-11-26 17:50:35 UTC 
Created attachment 209456 [details]
v1

Hi there

kde@ would like to ask for an exp-run to upgrade cmake to 3.16.0.

The patch is attached, and can also be found here:
https://people.freebsd.org/~tcberner/patches/cmake-3.16.0.v1.diff


mfg Tobias
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-12-07 20:08:10 UTC 
A commit references this bug:

Author: tcberner
Date: Sat Dec  7 20:07:58 UTC 2019
New revision: 519235
URL: https://svnweb.freebsd.org/changeset/ports/519235

Log:
  misc/openvdb: prepare for cmake-3.16.0

  PR:		242254

Changes:
  head/misc/openvdb/Makefile
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-07 20:16:23 UTC 
Created attachment 209777 [details]
v2

Second version of the patch:
https://people.freebsd.org/~tcberner/patches/cmake-3.16.0.v2.diff

This marks math/openmesh and science/fleur broken for now
Comment 7 grarpamp 2019-12-27 11:56:12 UTC 
You will need to update cmake to 3.16.2 since it is the
only version which supports the new boost 1.72.0 version
that landed in ports and packages 2 weeks ago.

https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindBoost.cmake
https://github.com/Kitware/CMake/commits/master/Modules/FindBoost.cmake
https://github.com/Kitware/CMake/releases/


ie: With 1.72.0, users are now being hit with these warnings
when the older cmake checks for boost version dependencies...

New Boost version may have incorrect or missing dependencies and imported targets...
Call Stack (most recent call first):
(_Boost_COMPONENT_DEPENDENCIES)
(_Boost_MISSING_DEPENDENCIES)
Comment 8 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-27 14:01:03 UTC 
Moin moin

Yes, still has the same failures in the two ports though and I did not yet have time to figure out why.


Mfg Tobias
Comment 9 Adriaan de Groot freebsd_committer freebsd_triage 2019-12-30 20:42:36 UTC 
Both of the two ports mentioned as failing (deal.II and qmcpack) build locally with poudriere; I suspect that they secretly were fixed by the Boost work or other commits.
Comment 10 Adriaan de Groot freebsd_committer freebsd_triage 2019-12-30 21:24:54 UTC 
Created attachment 210339 [details]
v3

This latest version of the patch updates to 3.16.2. Locally, the deal.II and qmcpack ports build with this version (and newer boost and whatnot that has happened since mid-december)
Comment 11 Antoine Brodin freebsd_committer freebsd_triage 2020-01-06 06:39:24 UTC 
Exp-run looks fine
Comment 12 commit-hook freebsd_committer freebsd_triage 2020-01-06 12:57:40 UTC 
A commit references this bug:

Author: adridg
Date: Mon Jan  6 12:57:05 UTC 2020
New revision: 522222
URL: https://svnweb.freebsd.org/changeset/ports/522222

Log:
  Update devel/cmake to latest upstream release, 3.16.2

  This new release has support for the latest Boost, Objective-C
  and various small improvements. The release notes are at:
  	https://cmake.org/cmake/help/v3.16/release/3.16.html

  Two ports could not be persuaded to build with this new release
  (math/openmesh science/fleur) and are marked BROKEN. Other build
  fixes have already been done in-tree.

  Thanks antoine@ for the exp-runs (multiple).
  Thanks tcberner@ for prep-work (most of the work, actually).

  PR:		242254

Changes:
  head/devel/cmake/Makefile
  head/devel/cmake/distinfo
  head/devel/cmake/files/patch-Source_CPack_cmCPackFreeBSDGenerator.cxx
  head/devel/cmake/pkg-plist
  head/devel/cmake-doc/Makefile
  head/devel/cmake-doc/pkg-plist
  head/devel/cmake-gui/Makefile
  head/devel/kms-cmake-utils/Makefile
  head/devel/kms-cmake-utils/pkg-plist
  head/math/casadi/Makefile
  head/math/openmesh/Makefile
  head/science/fleur/Makefile