|Summary:||lang/rust: useless dependency on gmake?|
|Product:||Ports & Packages||Reporter:||Mikael Urankar <mikael>|
|Component:||Individual Port(s)||Assignee:||FreeBSD Rust Team <rust>|
|Severity:||Affects Only Me||Flags:||tobik:
Description Mikael Urankar 2019-11-27 17:21:20 UTC
Hi, rust builds fine on 12.1 amd64 without gmake, not sure why it's listed as a build dep, any idea?
Comment 1 commit-hook 2019-11-29 22:13:03 UTC
A commit references this bug: Author: tobik Date: Fri Nov 29 22:12:36 UTC 2019 New revision: 518678 URL: https://svnweb.freebsd.org/changeset/ports/518678 Log: lang/rust, Mk/Uses/cargo.mk: Drop gmake build dependency for backtrace-sys The backtrace-sys crate no longer needs gmake since 0.1.20. sysutils/flowgger still uses backtrace-sys-0.1.14. Since it is the only USES=cargo port left that needs it, move the gmake dependency directly to it instead. lang/rust currently has backtrace-sys-0.1.30. It also vendors jemalloc-sys (which also needs gmake to build) but it is hidden behind rustc's jemalloc feature which we do not currently activate. It should be safe to remove gmake in lang/rust too. PR: 242267 Reported by: firstname.lastname@example.org Changes: head/Mk/Uses/cargo.mk head/lang/rust/Makefile head/net-im/fractal/Makefile head/sysutils/flowgger/Makefile
Comment 2 Tobias Kortkamp 2019-11-29 22:13:59 UTC
It seems to have been useless for a year or so. Thanks for noticing!