Bug 242278

Summary: security/libtasn1: fix build on GCC architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Roman Bogorodskiy <novel>
Status: Closed FIXED    
Severity: Affects Many People CC: novel
Priority: --- Flags: novel: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (novel)

Description Piotr Kubaj freebsd_committer 2019-11-28 09:00:17 UTC
Created attachment 209504 [details]
patch

After last update:
corpus2array.c:123: error: 'for' loop initial declaration used outside C99 mode

The attached patch fixes this issue.

This is pretty important, about 5000 ports fail because of this.
Comment 1 Roman Bogorodskiy freebsd_committer 2019-11-28 09:26:46 UTC
Thanks for reporting. Feel free to commit the fix as long as it was build tested.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-11-28 09:29:05 UTC
Approved as mentor.  (I had just now seen this on a build.)
Comment 3 commit-hook freebsd_committer 2019-11-28 10:38:03 UTC
A commit references this bug:

Author: pkubaj
Date: Thu Nov 28 10:37:18 UTC 2019
New revision: 518573
URL: https://svnweb.freebsd.org/changeset/ports/518573

Log:
  security/libtasn1: fix build on GCC architectures

  After last update the port uses C99:
  corpus2array.c:123: error: 'for' loop initial declaration used outside C99 mode

  PR:		242278
  Approved by:	novel (maintainer), linimon (mentor)

Changes:
  head/security/libtasn1/Makefile