Summary: | graphics/tesseract: openmp usage confusion on FreeBSD 12.1 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jonathan Chen <jonc> | ||||||||||
Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | Flags: | pkubaj:
maintainer-feedback+
|
||||||||||
Priority: | --- | ||||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
This doesn't work without including bsd.port.pre.mk: make: "/usr/ports/graphics/tesseract/Makefile" line 47: Malformed conditional (${OSVERSION} < 1201000) make: Fatal errors encountered -- cannot continue make: stopped in /usr/ports/graphics/tesseract Created attachment 209583 [details]
Conditional OPENMP_LIB_DEPENDS
Updated the patch. It builds on my 12.1 system, but I have no pre-12.1 system to test the patch against.
Created attachment 209712 [details]
Makefile patch
Fixed up stage errors and complaints.
(In reply to Jonathan Chen from comment #3) FreeBSD 11.3 also has libomp in base. Created attachment 209748 [details]
Conditional OPENMP_LIB_DEPENDS
Updated to handle libomp in 11.3 as well.
A commit references this bug: Author: pkubaj Date: Fri Dec 6 15:00:54 UTC 2019 New revision: 519148 URL: https://svnweb.freebsd.org/changeset/ports/519148 Log: graphics/tesseract: fix libomp dependency Use devel/openmp only on 12.0. PR: 242292 Submitted by: jonc@chen.org.nz Changes: head/graphics/tesseract/Makefile |
Created attachment 209522 [details] Condition OPENMP_LIB_DEPENDS FreeBSD 12.1 includes libomp in the base system. This confuses package validation OPENMP_LIB_DEPENDS=libomp.so:devel/openmp declares a dependency on devel/openmp that isn't fulfilled on 12.1+ during a build. I've included a patch that declares OPENMP_LIB_DEPENDS conditionally.