Summary: | www/caddy: Update to 1.0.4 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Shawn Wilsher <me> | ||||||||||
Component: | Individual Port(s) | Assignee: | Dmitri Goutnik <dmgk> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Some People | CC: | dmgk, fabian.freyer, viktor.dvz | ||||||||||
Priority: | --- | Keywords: | patch | ||||||||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(fabian.freyer) |
||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Description
Shawn Wilsher
2019-12-05 02:11:20 UTC
Test it on my FreeBSD 12.1-RELEASE-p1 GENERIC amd64, works fine. Just `caddy -version` show unknown It looks like I need to do some more modifications to get `caddy --version` to work: https://github.com/caddyserver/caddy/issues/2875 Although it is maybe worth noting that the current version of the port prints this: `Caddy (untracked dev build) (unofficial)` Created attachment 209947 [details]
caddy-1.0.4.diff v1.1
Fixes the `caddy --version` issue.
(In reply to Shawn Wilsher from comment #4) I've got an error: make: "/usr/ports/www/caddy/Makefile" line 35: Need an operator Created attachment 209988 [details]
caddy-1.0.4.diff v1.2
now with unix newlines
I'm uploading this on Windows, and was silly and did a copy and paste to get the diff onto the machine from my FreeBSD machine. This time I've used scp.
Rewrite by hand and test. Successfull Created attachment 210417 [details] caddy-1.0.4.diff v2 (In reply to Shawn Wilsher from comment #6) Hi, The patch is a good start but it's incomplete - it won't build in poudriere because upstream switched to go modules and doesn't vendor dependencies anymore. The attached patch fixes this and also unbreaks the build on aarch64 (https://github.com/caddyserver/caddy/pull/2956) Ah, I hadn't caught that since poudriere wasn't part of the steps in the porter's handbook. Thanks for catching and updating, Dmitri! A commit references this bug: Author: dmgk Date: Mon Jan 6 12:05:57 UTC 2020 New revision: 522216 URL: https://svnweb.freebsd.org/changeset/ports/522216 Log: www/caddy: Update to 1.0.4 - While here, unbreak on aarch64 (https://github.com/caddyserver/caddy/pull/2956) PR: 242441 Submitted by: Shawn Wilsher <me@shawnwilsher.com> Reviewed by: GremL1N <viktor.dvz@gmail.com>, dmgk Approved by: maintainer timeout (fabian.freyer@physik.tu-berlin.de, 1 month) Changes: head/www/caddy/Makefile head/www/caddy/distinfo Committed, thanks everyone. |