|Summary:||[PATCH] mail/postfix-postfwd: update to 2.02|
|Product:||Ports & Packages||Reporter:||Andreas Jobs <andreas.jobs+freebsdbugs>|
|Component:||Individual Port(s)||Assignee:||Dmitry Marakasov <amdmi3>|
|Severity:||Affects Only Me||CC:||andreas.jobs+freebsdbugs|
Description Andreas Jobs 2019-12-10 16:03:09 UTC
Created attachment 209835 [details] port upgrade to 2.02 postfwd3 (a.k.a. postfwd 2.02) is a drop-in replacement for postfwd1/postfwd2. Neither the ruleset nor the commandline arguments need any changes. From the orginal announcement: ---- postfwd3 is a drop-in replacement, which means that rulesets and command-line arguments don't need to be changed. The only exception is a small change to the plugin interface. If you use external plugins you should contact the author and ask if the new interface is supported. Plug-in developers will find the changes within the documentation and are encouraged to contact me, if they face any problems. Besides many new feature like multiple actions per rule, dynamic groups, full ipv6 support and lots of fixes and optimisations, postfwd3 combines the personalities of postfwd1 (single process multiplexer) and postfwd2 (multi process prefork). This facilitates the development process as the old versions used different codebases and every feature had to be coded twice in the past. You can switch between the personalities by command-line arguments. More information can be found in the changelog at https://postfwd.org/CHANGELOG and the documentation at https://postfwd.org/doc.html. ----
Comment 1 Dmitry Marakasov 2019-12-16 15:21:25 UTC
Could you please fix DEVELOPER=yes and portlint errors: --- /!\ postfix-postfwd-2.02_1: Makefile errors /!\ Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary, set DISTNAME --- --- WARN: Makefile: : USE_* seen before USES. According to the porters-handbook, USES must appear first. WARN: Makefile: : do not use muted INSTALL_foo commands (i.e., those that start with '@'). These should be printed. FATAL: Makefile: DISTVERSIONPREFIX appears out-of-order. FATAL: Makefile: extra item "USE_GITHUB" placed in the PORTNAME section. FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY. FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified, not both. WARN: Makefile: "USES" has to appear earlier. 4 fatal errors and 3 warnings found. --- Also would you like to take the maintainershup of this port?
Comment 2 Andreas Jobs 2019-12-17 11:57:32 UTC
Created attachment 210005 [details] port upgrade to 2.02
Comment 3 Andreas Jobs 2019-12-17 12:11:31 UTC
(In reply to Dmitry Marakasov from comment #1) Thank you for the hints. I've replaced my patch by a new one that does not throw any Makefile errors. portlint -C looks good too. I also would like to take the maintainership of this port.
Comment 4 commit-hook 2019-12-28 17:39:14 UTC
A commit references this bug: Author: amdmi3 Date: Sat Dec 28 17:38:50 UTC 2019 New revision: 521227 URL: https://svnweb.freebsd.org/changeset/ports/521227 Log: - Update to 2.02 - Pass maintainership to submitter PR: 242550 Submitted by: firstname.lastname@example.org Changes: head/mail/postfix-postfwd/Makefile head/mail/postfix-postfwd/distinfo head/mail/postfix-postfwd/pkg-plist
Comment 5 Dmitry Marakasov 2019-12-28 17:39:52 UTC
Note that I've had to fix plist (there were missing manpages and docs, however I've automated handling of the latter by switching to PORTDOCS=* PORTEXAMPLES=*)