Bug 242580

Summary: net-im/6cord: Unbreak on aarch64
Product: Ports & Packages Reporter: Dmitri Goutnik <dmgk>
Component: Individual Port(s)Assignee: Dmitri Goutnik <dmgk>
Status: Closed FIXED    
Severity: Affects Only Me CC: lcook
Priority: --- Flags: lcook: maintainer-feedback+
Version: Latest   
Hardware: arm64   
OS: Any   
Bug Depends on:    
Bug Blocks: 242312    
Attachments:
Description Flags
6cord-9.5_2.patch lcook: maintainer-approval+

Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-12-11 13:24:33 UTC
Created attachment 209865 [details]
6cord-9.5_2.patch

===>  Building 6cord from .
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518685_s355218/logs/errors/6cord-9.5_1.log

Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64. Upstream PR: https://gitlab.com/diamondburned/6cord/merge_requests/21

Tested on 12.1-STABLE/arm64 and 12.1-RELEASE/amd64.
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2019-12-11 13:33:04 UTC
Good work, approved. :)
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2019-12-11 13:47:20 UTC
On a similar note, I think it's best to merge this patch first then I'll update bug#242365 to avoid any conflicts.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-12-11 14:10:06 UTC
A commit references this bug:

Author: dmgk
Date: Wed Dec 11 14:09:42 UTC 2019
New revision: 519805
URL: https://svnweb.freebsd.org/changeset/ports/519805

Log:
  net-im/6cord: Unbreak on aarch64

  ===>  Building 6cord from .
  # golang.org/x/sys/unix
  vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

  http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p518685_s355218/logs/errors/6cord-9.5_1.log

  Unbreak by updating golang.org/x/sys to 33540a1f6037 which adds support for freebsd/arm64.
  Upstream PR: https://gitlab.com/diamondburned/6cord/merge_requests/21

  PR:		242580
  Approved by:	Lewis Cook <vulcan@wired.sh> (maintainer)

Changes:
  head/net-im/6cord/Makefile
  head/net-im/6cord/distinfo