Bug 242802
| Summary: | [snd:hda] fix no sound on headphones of Asus UX331UAL (ALC294) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Lutz Bichler <Lutz.Bichler> | ||||
| Component: | kern | Assignee: | freebsd-multimedia (Nobody) <multimedia> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | christos, emaste | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | 12.1-RELEASE | ||||||
| Hardware: | amd64 | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hello Lutz, I submitted your patch for review: https://reviews.freebsd.org/D45238 One question: what is the rationale behind using `config` for nid25, instead of `patch_str`? Hi Christos, if I remember right, I just did some pattern matching and was happy that it worked :-). It is quite likely that things should be done in a different way. Also, the code of hdaa_patches.c looked a bit different at the time this was done. Best regards Lutz A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=93ad59a251897431627345c287390ae134925a95 commit 93ad59a251897431627345c287390ae134925a95 Author: Lutz Bichler <Lutz.Bichler@gmail.com> AuthorDate: 2024-05-22 22:19:50 +0000 Commit: Christos Margiolis <christos@FreeBSD.org> CommitDate: 2024-05-22 22:19:50 +0000 snd_hda: Add patch for Asus UX331UAL PR: 242802 MFC after: 1 day Differential Revision: https://reviews.freebsd.org/D45238 sys/dev/sound/pci/hda/hdaa_patches.c | 11 +++++++++++ sys/dev/sound/pci/hda/hdac.h | 1 + 2 files changed, 12 insertions(+) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=1fb0a65ab2dd7f6fb5dfcac2d78b6dcb6e3c6c9e commit 1fb0a65ab2dd7f6fb5dfcac2d78b6dcb6e3c6c9e Author: Lutz Bichler <Lutz.Bichler@gmail.com> AuthorDate: 2024-05-22 22:19:50 +0000 Commit: Christos Margiolis <christos@FreeBSD.org> CommitDate: 2024-05-23 00:24:15 +0000 snd_hda: Add patch for Asus UX331UAL PR: 242802 MFC after: 1 day Differential Revision: https://reviews.freebsd.org/D45238 (cherry picked from commit 93ad59a251897431627345c287390ae134925a95) sys/dev/sound/pci/hda/hdaa_patches.c | 11 +++++++++++ sys/dev/sound/pci/hda/hdac.h | 1 + 2 files changed, 12 insertions(+) |
Created attachment 210138 [details] Enable headphone jack on Asus UX331UAL I need to apply the attached patch to enable sound on the headphone jack of an Asus UX331UAL.