Bug 242816

Summary: www/rubygem-rails60 invalid run dependency to rubygem-puma
Product: Ports & Packages Reporter: Matthias Fechner <mfechner>
Component: Individual Port(s)Assignee: Sunpoet Po-Chuan Hsieh <sunpoet>
Status: New ---    
Severity: Affects Many People Flags: bugzilla: maintainer-feedback? (sunpoet)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Remove puma dep from rails
none
Remove puma dep from rails none

Description Matthias Fechner freebsd_committer 2019-12-22 21:45:17 UTC
Created attachment 210161 [details]
Remove puma dep from rails

The current version has rubygem-puma as depedency.
Regarding this page, there is now run-time depedency for puma:
https://rubygems.org/gems/rails/versions/5.2.4

The new gitlab 12.6.0 version uses:
https://rubygems.org/gems/gitlab-puma

Both puma and gitlab-puma are installing a binary with the same name.
Removing puma from rails52 fixes the problem.

What do you think about the attached patch?
Comment 1 Matthias Fechner freebsd_committer 2020-04-18 07:16:27 UTC
Ping.
Comment 2 Matthias Fechner freebsd_committer 2020-04-18 07:16:55 UTC
Created attachment 213527 [details]
Remove puma dep from rails
Comment 3 Matthias Fechner freebsd_committer 2020-04-18 07:23:45 UTC
Gitlab will switch from unicorn to gitlab-puma.
But gitlab-puma will have a collision with puma.

As puma is not a runtime dependency:
https://rubygems.org/gems/rails

I suggest to remove it here to make it possible in the future to switch for gitlab to gitlab-puma.

I understand the convenience it brings, but if a port requires puma, it should have it as a runtime dep.

Could you please remove puma from the dep list?